automatic: use email_port specified in config #1956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows user to override the default SMTP port. Resolves rpm-software-management#1955.
rathann
added a commit
to rathann/dnf
that referenced
this pull request
Jun 28, 2023
Add the ability to use STARTTLS/TLS for sending e-mail via the `email` emitter. The `email_tls` option supports three settings: ``starttls``, used to switch to TLS on plaintext ports like 25 or 587 and ``yes``, used to wrap the entire connection in TLS, usually on port 465. Any other setting (``off`` by default) will use plain unencrypted SMTP. Note: this depends on rpm-software-management#1956 . = changelog = msg: Add `email_tls` option to DNF Automatic type: enhancement resolves: rpm-software-management#1954
|
The pr is ok. I would add a default option in the automatic.conf file. Also, I would document the option in the reference file. Could you please add this change? |
|
hi @rathann, any update? |
|
Sorry, @inknos, I've been too busy to make the requested changes. I'll try to make some time this week. |
rathann
added a commit
to rathann/dnf
that referenced
this pull request
Aug 15, 2023
Add the ability to use STARTTLS/TLS for sending e-mail via the `email` emitter. The `email_tls` option supports three settings: ``starttls``, used to switch to TLS on plaintext ports like 25 or 587 and ``yes``, used to wrap the entire connection in TLS, usually on port 465. Any other setting (``off`` by default) will use plain unencrypted SMTP. Note: this depends on rpm-software-management#1956 . = changelog = msg: Add `email_tls` option to DNF Automatic type: enhancement resolves: rpm-software-management#1954
|
waiting for CI to finish, then looks good to me |
rathann
added a commit
to rathann/dnf
that referenced
this pull request
Aug 31, 2023
Add the ability to use STARTTLS/TLS for sending e-mail via the `email` emitter. The `email_tls` option supports three settings: ``starttls``, used to switch to TLS on plaintext ports like 25 or 587 and ``yes``, used to wrap the entire connection in TLS, usually on port 465. Any other setting (``off`` by default) will use plain unencrypted SMTP. Note: this depends on rpm-software-management#1956 . = changelog = msg: Add `email_tls` option to DNF Automatic type: enhancement resolves: rpm-software-management#1954
inknos
pushed a commit
that referenced
this pull request
Aug 31, 2023
Add the ability to use STARTTLS/TLS for sending e-mail via the `email` emitter. The `email_tls` option supports three settings: ``starttls``, used to switch to TLS on plaintext ports like 25 or 587 and ``yes``, used to wrap the entire connection in TLS, usually on port 465. Any other setting (``off`` by default) will use plain unencrypted SMTP. Note: this depends on #1956 . = changelog = msg: Add `email_tls` option to DNF Automatic type: enhancement resolves: #1954
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows user to override the default SMTP port.
Resolves #1955.