Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

email_port option supported but not used #1955

Closed
rathann opened this issue Jun 28, 2023 · 3 comments · Fixed by #1956
Closed

email_port option supported but not used #1955

rathann opened this issue Jun 28, 2023 · 3 comments · Fixed by #1956
Assignees
@inknos

Comments

@rathann
Copy link
Contributor

rathann commented Jun 28, 2023

It looks like the email_port option, while parsed in dnf/automatic/main.py:200, is not actually used anywhere.
rathann added a commit to rathann/dnf that referenced this issue Jun 28, 2023
@rathann
automatic: use email_port specified in config
6c65b38 
This allows user to override the default SMTP port.

Resolves rpm-software-management#1955.
@rathann rathann mentioned this issue Jun 28, 2023
Merged
@inknos
Copy link
Contributor

inknos commented Jul 24, 2023

hi @rathann , good catch, the option could be implemented. just a couple of questions.

  • what's your use case?
  • would you like to implement the option?

Thank you.

@rathann
Copy link
Contributor Author

rathann commented Jul 24, 2023

hi @rathann , good catch, the option could be implemented. just a couple of questions.

* what's your use case?

My use case is running dnf-automatic on a VM in Oracle Cloud Free Tier, where outgoing port 25 is blocked by default and there's no option to unblock it without moving to a paid tier.

* would you like to implement the option?

Already did. See #1956 .

@inknos
Copy link
Contributor

inknos commented Jul 24, 2023

Already did. See #1956 .

Oh! I didn't notice, thanks I'll review it

inknos pushed a commit that referenced this issue Aug 29, 2023
@rathann @inknos
automatic: use email_port specified in config
fd27e77 
This allows user to override the default SMTP port.

Resolves #1955.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inknos inknos

Labels
None yet
Projects
DNF team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

automatic: use email_port specified in config rathann/dnf
2 participants
@rathann @inknos