automatic: allow use of STARTTLS/TLS #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
waiting for CI to finish, then looks good to me |
|
duh, I didn't catch that here is a conflict after merging #1956. sorry for another request but would you mind rebasing? |
Add the ability to use STARTTLS/TLS for sending e-mail via the `email` emitter. The `email_tls` option supports three settings: ``starttls``, used to switch to TLS on plaintext ports like 25 or 587 and ``yes``, used to wrap the entire connection in TLS, usually on port 465. Any other setting (``off`` by default) will use plain unencrypted SMTP. Note: this depends on rpm-software-management#1956 . = changelog = msg: Add `email_tls` option to DNF Automatic type: enhancement resolves: rpm-software-management#1954
No problem, rebased on top of current master HEAD and force-pushed. |
|
Should I add myself to AUTHORS ? |
thanks a lot
definitely, feel free to add yourself to the contributors list! |
|
Thanks! as soon as the CI finishes I will merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to use STARTTLS/TLS for sending e-mail via the
emailemitter.
The
email_tlsoption supports three settings:starttls, used toswitch to TLS on plaintext ports like 25 or 587 and
yes, used towrap the entire connection in TLS, usually on port 465. Any other
setting (
offby default) will use plain unencrypted SMTP.Note: this depends on #1956 .
= changelog =
msg: Add
email_tlsoption to DNF Automatictype: enhancement
resolves: #1954