Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use double when handling qreal orient_ #114

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Use double when handling qreal orient_ #114

merged 1 commit into from
Dec 20, 2021

Commits on Dec 20, 2021

  1. Use double when handling qreal orient_ 

    When the value of `orient_` crosses the boundary of `float`, e.g., when
`cmd_vel.angular.z = -4.0e+214`, `normalizeAngle` returns `nan`.
As a result, `x`, `y`, and `theta` all become `nan`, and turtle disappears
from the frame.

As `qreal` corresponds to `double`, `normalizeAngle` should be taking param
`angle` as `double`, and return `double` accordingly.
    @squizz617 @paudrow
    squizz617 authored and paudrow committed Dec 20, 2021
    Configuration menu
    Copy the full SHA
    a7c2d9e View commit details
    Browse the repository at this point in the history