Use double when handling qreal orient_
#114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the value of `orient_` crosses the boundary of `float`, e.g., when `cmd_vel.angular.z = -4.0e+214`, `normalizeAngle` returns `nan`. As a result, `x`, `y`, and `theta` all become `nan`, and turtle disappears from the frame. As `qreal` corresponds to `double`, `normalizeAngle` should be taking param `angle` as `double`, and return `double` accordingly.
audrow
approved these changes
Dec 20, 2021
There was a problem hiding this comment.
This seems like a good fix. Dashing is EOL, so I made this PR target rolling and rebased your commit. Thanks for the PR, @squizz617!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the value of
orient_crosses the boundary offloat, e.g., whencmd_vel.angular.z = -4.0e+214,normalizeAnglereturnsnan.As a result,
x,y, andthetaall becomenan, and turtle disappearsfrom the frame.
As
qrealcorresponds todouble,normalizeAngleshould be taking paramangleasdouble, and returndoubleaccordingly.