Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-fix isset check and revert PR #539 #546

Merged
merged 5 commits into from
Nov 10, 2021
Merged

Re-fix isset check and revert PR #539 #546

merged 5 commits into from
Nov 10, 2021

Conversation

bishopb
Copy link
Contributor

@bishopb bishopb commented Nov 8, 2021

Description of the change

Reverts commit 666a1a2, which altered the expected type of the reportSuppressed internal variable from boolean to the type of the user-supplied configuration value. Additionally, this allowed for potential malicious value injection, as the value of the configuration key was not checked.

Then, adds a test that exposes the bug associated with PR #539.

Finally, fixes said bug.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@bishopb bishopb requested a review from bxsx November 8, 2021 15:02
@bishopb bishopb changed the title Revert 666a1a2 Revert PR #539 Nov 8, 2021
@bxsx bxsx changed the title Revert PR #539 Re-fix isset check and revert PR #539 Nov 9, 2021
@bishopb bishopb merged commit ad22e35 into master Nov 10, 2021
@bishopb bishopb deleted the revert-666a1a2 branch November 12, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants