Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-539-backport-1.x: Fix isset check #542

Closed
wants to merge 1 commit into from

Conversation

bxsx
Copy link
Contributor

@bxsx bxsx commented Oct 29, 2021

Description of the change

Backport of the #539 to the 1.x version.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

#539

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@bxsx bxsx self-assigned this Oct 29, 2021
@bxsx bxsx changed the title Backport #539 to 1.x GH-539-backport: Fix isset check Nov 2, 2021
@bxsx bxsx changed the title GH-539-backport: Fix isset check GH-539-backport-1.x: Fix isset check Nov 2, 2021
Copy link
Contributor

@bishopb bishopb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure the implementation in main has full test coverage and is non breaking, before backporting.

@bxsx
Copy link
Contributor Author

bxsx commented Nov 9, 2021

Since #546 is a successor to the backported #539, it seems this PR is no longer valid.

@bishopb If the new fix provided in #546 can be backported, please open a new PR for the backport.
Thanks!

@bxsx bxsx closed this Nov 9, 2021
@bxsx bxsx deleted the 1.x-backport-fix-isset branch November 9, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants