Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-fix isset check and revert PR #539 #546

Merged
merged 5 commits into from
Nov 10, 2021
Merged

Re-fix isset check and revert PR #539 #546

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7821cb7
Revert "Merge pull request #539 from trsteel88/master"
Nov 8, 2021
fc9eb80
feat: add test coverage for shouldSuppress()
Nov 8, 2021
ca1f8f7
fix: incorrect check for report_suppressed setting
Nov 8, 2021
2790fba
refac: remove extraneous whitespace
Nov 8, 2021
8bc8cc7
doc: note when new public method became available
Nov 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: incorrect check for report_suppressed setting
  • Loading branch information
Bishop Bettini committed Nov 8, 2021
commit ca1f8f7baa728d559de8e9b02d3a6da3c602ad60
4 changes: 2 additions & 2 deletions src/Config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,11 +450,11 @@ private function setMinimumLevel(array $config): void
private function setReportSuppressed(array $config): void
{
$this->reportSuppressed = isset($config['reportSuppressed']) && $config['reportSuppressed'];
if (!isset($this->reportSuppressed)) {
if (!$this->reportSuppressed) {
$this->reportSuppressed = isset($config['report_suppressed']) && $config['report_suppressed'];
}

if (!isset($this->reportSuppressed)) {
if (!$this->reportSuppressed) {
$this->reportSuppressed = \Rollbar\Defaults::get()->reportSuppressed();
}
}
Expand Down