[core][dashboard] Add repr_name as part of actor state #33555

rickyyx · 2023-03-21T22:05:37Z

Why are these changes needed?

If an actor has __repr__ defined, one could retrieve the actor's repr name in the actor data.
Example:

    from ray.experimental.state.api import get_actor
    get_actor,
    @ray.remote
    class ReprActor:
        def __init__(self, x) -> None:
            self.x = x

        def __repr__(self) -> str:
            return self.x

        def ready(self):
            pass

    a = ReprActor.remote(x="repr-name-a")
    actor = get_actor(id=a._actor_id.hex())
    assert actor["repr_name"] == "repr-name-a"

This PR adds the actor's repr name as part of the PushTaskReply when executing actor creation task on the executor, and stores it as part of GCS actor table.

A couple of places where the repr name will now show up:

Task summary (we will likely use "group_name" in the future)
Repr name on actor table as another column
Repr name on actor detail.

@ray.remote
class Actor:
    pass


@ray.remote
class ActorClass:
    def __repr__(self) -> str:
        return "hi"

Related issue number

Closes #

Checks

I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
I've run scripts/format.sh to lint the changes in this PR.
I've included any doc changes needed for https://docs.ray.io/en/master/.
- I've added any new APIs to the API Reference. For example, if I added a
  method in Tune, I've added it in doc/source/tune/api/ under the
  corresponding .rst file.
I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
Testing Strategy
- Unit tests
- Release tests
- This PR is not tested :(

Signed-off-by: rickyyx <[email protected]>

rkooo567

only nit comments

src/ray/protobuf/gcs.proto

python/ray/_raylet.pyx

…epr-actor-name

Signed-off-by: rickyyx <[email protected]>

rickyyx · 2023-03-22T18:25:06Z

The cpp-tests-asan is flaky due to this: #33475

rkooo567 · 2023-03-22T21:49:56Z

cc @wuisawesome can you review the gcs.proto change

rickyyx · 2023-03-22T23:26:06Z

Adding frontend changes to the PR as well.

Signed-off-by: rickyyx <[email protected]>

rickyyx · 2023-03-23T02:31:01Z

Added frontend changes.

Signed-off-by: rickyyx <[email protected]>

rkooo567 · 2023-03-23T05:57:04Z

Some test failiure seems related?

python/ray/experimental/state/common.py

rkooo567 · 2023-03-23T06:00:19Z

dashboard/client/src/type/actor.ts

@@ -30,6 +30,7 @@ export type Actor = {
 [key: string]: number;
 };
 exitDetail: string;
+ reprName: string;


Isn't this supposed to be optional? Or does it always exist?

it will always exist, as an empty string if no repr is defined on the actor.

Signed-off-by: rickyyx <[email protected]>

python/ray/experimental/state/common.py

rkooo567 · 2023-03-23T07:23:22Z

Lmk when tests pass!

This reverts commit 334ee66.

…3555) This PR adds the actor's repr name as part of the PushTaskReply when executing actor creation task on the executor, and stores it as part of GCS actor table. A couple of places where the repr name will now show up: Task summary (we will likely use "group_name" in the future) Repr name on actor table as another column Repr name on actor detail.

…3555) This PR adds the actor's repr name as part of the PushTaskReply when executing actor creation task on the executor, and stores it as part of GCS actor table. A couple of places where the repr name will now show up: Task summary (we will likely use "group_name" in the future) Repr name on actor table as another column Repr name on actor detail. Signed-off-by: bhuang <[email protected]>

…3555) This PR adds the actor's repr name as part of the PushTaskReply when executing actor creation task on the executor, and stores it as part of GCS actor table. A couple of places where the repr name will now show up: Task summary (we will likely use "group_name" in the future) Repr name on actor table as another column Repr name on actor detail. Signed-off-by: Jonathan Carter <[email protected]>

…3555) This PR adds the actor's repr name as part of the PushTaskReply when executing actor creation task on the executor, and stores it as part of GCS actor table. A couple of places where the repr name will now show up: Task summary (we will likely use "group_name" in the future) Repr name on actor table as another column Repr name on actor detail. Signed-off-by: elliottower <[email protected]>

…3555) This PR adds the actor's repr name as part of the PushTaskReply when executing actor creation task on the executor, and stores it as part of GCS actor table. A couple of places where the repr name will now show up: Task summary (we will likely use "group_name" in the future) Repr name on actor table as another column Repr name on actor detail. Signed-off-by: Jack He <[email protected]>

init

4e5a51f

Signed-off-by: rickyyx <[email protected]>

rickyyx assigned rkooo567 Mar 21, 2023

rickyyx requested review from a team, wuisawesome, ericl, AmeerHajAli, robertnishihara, pcmoritz, raulchen, fishbone and scv119 as code owners March 21, 2023 22:05

rickyyx assigned ericl Mar 21, 2023

rkooo567 approved these changes Mar 21, 2023

View reviewed changes

src/ray/protobuf/gcs.proto Show resolved Hide resolved

python/ray/_raylet.pyx Outdated Show resolved Hide resolved

rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Mar 21, 2023

rickyyx added 2 commits March 21, 2023 23:53

Merge branch 'master' of https://github.com/ray-project/ray into pr-r…

21bd479

…epr-actor-name

comments

4759c5c

Signed-off-by: rickyyx <[email protected]>

rickyyx removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Mar 22, 2023

rkooo567 assigned wuisawesome Mar 22, 2023

wuisawesome approved these changes Mar 22, 2023

View reviewed changes

rickyyx mentioned this pull request Mar 23, 2023

[core][state] List actors should show actors from dead jobs as well #31984

Closed

7 tasks

update

045bc95

Signed-off-by: rickyyx <[email protected]>

rickyyx assigned alanwguo Mar 23, 2023

rickyyx added 2 commits March 23, 2023 02:31

format

93d4ab1

Signed-off-by: rickyyx <[email protected]>

fix

03fa485

Signed-off-by: rickyyx <[email protected]>

rkooo567 reviewed Mar 23, 2023

View reviewed changes

python/ray/experimental/state/common.py Show resolved Hide resolved

rkooo567 requested changes Mar 23, 2023

View reviewed changes

rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Mar 23, 2023

fix

95287c5

Signed-off-by: rickyyx <[email protected]>

rkooo567 approved these changes Mar 23, 2023

View reviewed changes

python/ray/experimental/state/common.py Show resolved Hide resolved

rkooo567 merged commit 334ee66 into ray-project:master Mar 23, 2023

ollie-iterators mentioned this pull request Mar 23, 2023

Tests are not being run because of https://github.com/ray-project/ray/pull/33555 #33634

Closed

rickyyx added a commit that referenced this pull request Mar 23, 2023

Revert "[core][dashboard] Add repr_name as part of actor state (#33555)"

a2d284e

This reverts commit 334ee66.

This was referenced Mar 23, 2023

Revert "[core][dashboard] Add repr_name as part of actor state" #33635

Closed

[ci] Rebuild dashboard client on PR so that build errors could be caught on PR early. #33638

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[core][dashboard] Add repr_name as part of actor state #33555

[core][dashboard] Add repr_name as part of actor state #33555

rickyyx commented Mar 21, 2023 •

edited

Loading

rkooo567 left a comment

rickyyx commented Mar 22, 2023

rkooo567 commented Mar 22, 2023

rickyyx commented Mar 22, 2023

rickyyx commented Mar 23, 2023

rkooo567 commented Mar 23, 2023

rkooo567 Mar 23, 2023

rickyyx Mar 23, 2023 •

edited

Loading

rkooo567 commented Mar 23, 2023

[core][dashboard] Add repr_name as part of actor state #33555

[core][dashboard] Add repr_name as part of actor state #33555

Conversation

rickyyx commented Mar 21, 2023 • edited Loading

Why are these changes needed?

Related issue number

Checks

rkooo567 left a comment

Choose a reason for hiding this comment

rickyyx commented Mar 22, 2023

rkooo567 commented Mar 22, 2023

rickyyx commented Mar 22, 2023

rickyyx commented Mar 23, 2023

rkooo567 commented Mar 23, 2023

rkooo567 Mar 23, 2023

Choose a reason for hiding this comment

rickyyx Mar 23, 2023 • edited Loading

Choose a reason for hiding this comment

rkooo567 commented Mar 23, 2023

rickyyx commented Mar 21, 2023 •

edited

Loading

rickyyx Mar 23, 2023 •

edited

Loading