Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core][state] List actors should show actors from dead jobs as well #31984

Closed
wants to merge 16 commits into from
Closed

[core][state] List actors should show actors from dead jobs as well #31984

wants to merge 16 commits into from

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Jan 27, 2023

Signed-off-by: rickyyx [email protected]

Why are these changes needed?

This is to enable use cases by the dashboard.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rickyyx
init
2986d9f 
Signed-off-by: rickyyx <[email protected]>
@rickyyx rickyyx added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jan 27, 2023
@rickyyx
default true
9b815e3 
Signed-off-by: rickyyx <[email protected]>
@rickyyx
default
e682b4e 
Signed-off-by: rickyyx <[email protected]>
@rickyyx
merge conflict
d3a5104 
Signed-off-by: rickyyx <[email protected]>
@rickyyx rickyyx removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Jan 31, 2023
@rickyyx
Copy link
Contributor Author

rickyyx commented Jan 31, 2023

Let's try deprecate the show_dead_jobs flag from gcs maybe later?

I set it to True for state API though.

rkooo567
rkooo567 requested changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes until we figure out the test failure

python/ray/tests/test_state_api_summary.py Outdated Show resolved Hide resolved
@rickyyx rickyyx added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Feb 1, 2023
@stale
Copy link

stale bot commented Mar 11, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

  • If you'd like to keep this open, just leave any comment, and the stale label will be removed.

@stale stale bot added the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Mar 11, 2023
@rickyyx
Copy link
Contributor Author

rickyyx commented Mar 14, 2023

TODO

@stale stale bot removed the stale The issue is stale. It will be closed within 7 days unless there are further conversation label Mar 14, 2023
@rickyyx rickyyx mentioned this pull request Mar 20, 2023
Open
@rickyyx rickyyx requested a review from a team as a code owner March 23, 2023 01:46
@rickyyx
fix
a736358 
Signed-off-by: rickyyx <[email protected]>
@rickyyx rickyyx removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Mar 23, 2023
@rickyyx
Copy link
Contributor Author

rickyyx commented Mar 23, 2023

We need this PR for #33555 since we will need to list actors to get the "repr_name" when summarizing tasks including actor tasks.

@rickyyx rickyyx requested a review from rkooo567 March 23, 2023 01:55
@rickyyx rickyyx changed the title [core][state] Add flag to allow listing actors from dead jobs [core][state] List actors should show actors from dead jobs as well Mar 23, 2023
rkooo567
rkooo567 requested changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One potential race condition comment.

src/ray/gcs/gcs_server/gcs_actor_manager.cc Outdated Show resolved Hide resolved
src/ray/gcs/gcs_server/gcs_actor_manager.cc Outdated Show resolved Hide resolved
@rkooo567
Copy link
Contributor

also let's make sure to run stress_test_dead_actors before merging the PR

@rkooo567 rkooo567 added the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Mar 24, 2023
@rkooo567
Copy link
Contributor

Instead of handling the persistency issue, we decided to just use cache directly

@rickyyx
Copy link
Contributor Author

rickyyx commented Apr 5, 2023 •
edited
Loading

So - this becomes no op after we decide to read from cache + dead job's actors not cleaned up eagerly.

Do we want to merge the test? Or feel free to just close the PR. cc @rkooo567

@rickyyx rickyyx removed the @author-action-required The PR author is responsible for the next step. Remove tag to send back to the reviewer. label Apr 5, 2023
@rkooo567 rkooo567 closed this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkooo567 rkooo567 rkooo567 requested changes

Assignees

@alanwguo alanwguo

@rkooo567 rkooo567

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rickyyx @rkooo567 @alanwguo