Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are not being run because of https://github.com/ray-project/ray/pull/33555 #33634

Closed
ollie-iterators opened this issue Mar 23, 2023 · 0 comments · Fixed by #33637
Labels
bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component)

Comments

@ollie-iterators
Copy link

ollie-iterators commented Mar 23, 2023

What happened + What you expected to happen

When the Pull Request #33555 was merged, the number of tests ran dropped from 116 to 14.

Before:
Screenshot 2023-03-23 at 1 00 20 PM

After:
Screenshot 2023-03-23 at 1 00 35 PM

Errors for these tests:
Screenshot 2023-03-23 at 12 04 15 PM

Are causing tests to not be run on ray.
Screenshot 2023-03-23 at 12 03 58 PM

NOTE: If I could put something higher than the High severity, I would do it.

Versions / Dependencies

Main branch

Reproduction script

Look at https://flakey-tests.ray.io/

Issue Severity

High: It blocks me from completing my task.

@ollie-iterators ollie-iterators added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Mar 23, 2023
@ollie-iterators ollie-iterators changed the title Tests are not being run because of errors Tests are not being run because of https://github.com/ray-project/ray/pull/33555 Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant