Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[State API/Dashboard] UX issues with Ray list actors #33484

Open
scottsun94 opened this issue Mar 20, 2023 · 6 comments
Open

[State API/Dashboard] UX issues with Ray list actors #33484

scottsun94 opened this issue Mar 20, 2023 · 6 comments
Assignees
@rickyyx
Labels
bug Something that is supposed to be working; but isn't dashboard Issues specific to the Ray Dashboard observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling P1 Issue that should be fixed within a few weeks
Milestone
Ray State Observa...

Comments

@scottsun94
Copy link
Contributor

scottsun94 commented Mar 20, 2023 •
edited
Loading

What happened + What you expected to happen

I ran a simple tune script and at the end, there are 4 dead actors. I tried to use ray list actors and I noticed several issues:
Screen Shot 2023-03-20 at 3 39 57 PM

  1. The response No resource in the cluster is a bit ambiguous. Ray resource/resource usually refers to logical resources. Ideally, it should be "No actors found in the cluster". If we want to make it more generic so that it should be reused across tasks, objects, etc., maybe something like "None found in the cluster"? (this issue applies to other list commands like ray list objects)

Screen Shot 2023-03-20 at 3 40 46 PM

  1. I was surprised to find out that dead actors are ignored. If an actor failed, I need to find it?

Versions / Dependencies

nightly

Reproduction script

n/a

Issue Severity

None
@scottsun94 scottsun94 added bug Something that is supposed to be working; but isn't triage Needs triage (eg: priority, bug/not-bug, and owning component) labels Mar 20, 2023
@scottsun94 scottsun94 added observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling dashboard Issues specific to the Ray Dashboard labels Mar 20, 2023
@rickyyx
Copy link
Contributor

rickyyx commented Mar 20, 2023

re1: Yes, I think we could handle this one better.
re2: So right now we are not returning these actors if the job has finished, I have a PR #31984 to be iterated.

@rkooo567
Copy link
Contributor

@rickyyx I think actually 2 is due to #31019

@rkooo567
Copy link
Contributor

we should merge this PR. I will try to so by 2.4

@rickyyx
Copy link
Contributor

rickyyx commented Mar 20, 2023

I think we need both #31019 and #31984 to see dead actors from finished jobs?

@rkooo567
Copy link
Contributor

ah you are right!

@hora-anyscale hora-anyscale added the core Issues that should be addressed in Ray Core label Mar 24, 2023
@rkooo567 rkooo567 added P1 Issue that should be fixed within a few weeks and removed triage Needs triage (eg: priority, bug/not-bug, and owning component) core Issues that should be addressed in Ray Core labels Mar 29, 2023
@rkooo567 rkooo567 added this to the Ray State Observability milestone Mar 29, 2023
@rkooo567
Copy link
Contributor

not a core bug. we will handle this as a part of state API cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rickyyx rickyyx

Labels
bug Something that is supposed to be working; but isn't dashboard Issues specific to the Ray Dashboard observability Issues related to the Ray Dashboard, Logging, Metrics, Tracing, and/or Profiling P1 Issue that should be fixed within a few weeks
Projects
None yet
Milestone
Ray State Observability
Development

No branches or pull requests
4 participants
@scottsun94 @rickyyx @rkooo567 @hora-anyscale