Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Fix issues with PS1 with conda activate #30911

Merged
merged 1 commit into from
Dec 6, 2022
Merged

[ci] Fix issues with PS1 with conda activate #30911

merged 1 commit into from
Dec 6, 2022

Conversation

rickyyx
Copy link
Contributor

@rickyyx rickyyx commented Dec 6, 2022 •
edited
Loading

Signed-off-by: rickyyx [email protected]

Why are these changes needed?

With some searching, seems to be a similar issue (conda/conda#8186) with activating conda in bash script. However, it could also be unrelated. The major correlation is from where this error is thrown. I believe the error is raised when initializing conda when doing source ~/.zshrc, and we did change some of the scripting options in this PR(#27495) and its original revert.

So the hypothesis is because ci.sh changes some of the scripting options, and with &&, it also interferes with source ~/.zshrc which initializes conda.

image

Related issue number

Closes #30686
Closes #26194

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@rickyyx
try try
9609746 
Signed-off-by: rickyyx <[email protected]>
@rickyyx
Copy link
Contributor Author

rickyyx commented Dec 6, 2022 •
edited
Loading

However, this is still a mystery why this is non-deterministic.

@rickyyx
Copy link
Contributor Author

rickyyx commented Dec 6, 2022

Triggered mac os build.

krfricke
krfricke approved these changes Dec 6, 2022
View reviewed changes
Copy link
Contributor

@krfricke krfricke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - wow, this is subtle

@rkooo567 rkooo567 merged commit 5a42b5a into ray-project:master Dec 6, 2022
@rickyyx
Copy link
Contributor Author

rickyyx commented Dec 6, 2022

Well apparently it doesn't work.

@rickyyx rickyyx mentioned this pull request Dec 12, 2022
Merged
7 tasks
krfricke pushed a commit that referenced this pull request Dec 16, 2022
@rickyyx
[all_tests][ci] Use .zshenv to avoid conda setting up breaks the pipe…
9bf1f57 
…line (#30999)

We have seen mac wheel build failures like when setting up the environment. 

The error was raised when doing `source ~/.zshrc` which contains 
- an export PATH to include bazel that `ci.sh init` puts in
- default conda activation code comes with the sandbox. 

We don't use condas for the mac builds and tests I believe, and this PR moves the PATH export to `.zshenv` for environment.

(This also reverts the PR: #30911) 

Signed-off-by: rickyyx <[email protected]>
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@rickyyx @WeichenXu123
[ci] Fix issues with PS1 with conda activate (ray-project#30911)
f1bb67b 
Signed-off-by: rickyyx <[email protected]>

With some searching, seems to be a similar issue (conda/conda#8186) with activating conda in bash script. However, it could also be unrelated. The major correlation is from where this error is thrown. I believe the error is raised when initializing conda when doing source ~/.zshrc, and we did change some of the scripting options in this PR(ray-project#27495) and its original revert.

So the hypothesis is because ci.sh changes some of the scripting options, and with &&, it also interferes with source ~/.zshrc which initializes conda.

Signed-off-by: Weichen Xu <[email protected]>
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@rickyyx @WeichenXu123
[all_tests][ci] Use .zshenv to avoid conda setting up breaks the pipe…
563d342 
…line (ray-project#30999)

We have seen mac wheel build failures like when setting up the environment.

The error was raised when doing `source ~/.zshrc` which contains
- an export PATH to include bazel that `ci.sh init` puts in
- default conda activation code comes with the sandbox.

We don't use condas for the mac builds and tests I believe, and this PR moves the PATH export to `.zshenv` for environment.

(This also reverts the PR: ray-project#30911)

Signed-off-by: rickyyx <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
Capiru pushed a commit to Capiru/ray that referenced this pull request Dec 21, 2022
@rickyyx @Capiru
[ci] Fix issues with PS1 with conda activate (ray-project#30911)
73d3de0 
Signed-off-by: rickyyx <[email protected]>

With some searching, seems to be a similar issue (conda/conda#8186) with activating conda in bash script. However, it could also be unrelated. The major correlation is from where this error is thrown. I believe the error is raised when initializing conda when doing source ~/.zshrc, and we did change some of the scripting options in this PR(ray-project#27495) and its original revert.

So the hypothesis is because ci.sh changes some of the scripting options, and with &&, it also interferes with source ~/.zshrc which initializes conda.

Signed-off-by: Capiru <[email protected]>
Capiru pushed a commit to Capiru/ray that referenced this pull request Dec 21, 2022
@rickyyx @Capiru
[ci] Fix issues with PS1 with conda activate (ray-project#30911)
4a27d5f 
Signed-off-by: rickyyx <[email protected]>

With some searching, seems to be a similar issue (conda/conda#8186) with activating conda in bash script. However, it could also be unrelated. The major correlation is from where this error is thrown. I believe the error is raised when initializing conda when doing source ~/.zshrc, and we did change some of the scripting options in this PR(ray-project#27495) and its original revert.

So the hypothesis is because ci.sh changes some of the scripting options, and with &&, it also interferes with source ~/.zshrc which initializes conda.

Signed-off-by: Capiru <[email protected]>
Capiru pushed a commit to Capiru/ray that referenced this pull request Dec 22, 2022
@rickyyx @Capiru
[ci] Fix issues with PS1 with conda activate (ray-project#30911)
609ff06 
Signed-off-by: rickyyx <[email protected]>

With some searching, seems to be a similar issue (conda/conda#8186) with activating conda in bash script. However, it could also be unrelated. The major correlation is from where this error is thrown. I believe the error is raised when initializing conda when doing source ~/.zshrc, and we did change some of the scripting options in this PR(ray-project#27495) and its original revert.

So the hypothesis is because ci.sh changes some of the scripting options, and with &&, it also interferes with source ~/.zshrc which initializes conda.

Signed-off-by: Capiru <[email protected]>
Capiru pushed a commit to Capiru/ray that referenced this pull request Dec 22, 2022
@rickyyx @Capiru
[all_tests][ci] Use .zshenv to avoid conda setting up breaks the pipe…
9a1f117 
…line (ray-project#30999)

We have seen mac wheel build failures like when setting up the environment.

The error was raised when doing `source ~/.zshrc` which contains
- an export PATH to include bazel that `ci.sh init` puts in
- default conda activation code comes with the sandbox.

We don't use condas for the mac builds and tests I believe, and this PR moves the PATH export to `.zshenv` for environment.

(This also reverts the PR: ray-project#30911)

Signed-off-by: rickyyx <[email protected]>
Signed-off-by: Capiru <[email protected]>
AmeerHajAli pushed a commit that referenced this pull request Jan 12, 2023
@rickyyx @AmeerHajAli
[all_tests][ci] Use .zshenv to avoid conda setting up breaks the pipe…
340a193 
…line (#30999)

We have seen mac wheel build failures like when setting up the environment. 

The error was raised when doing `source ~/.zshrc` which contains 
- an export PATH to include bazel that `ci.sh init` puts in
- default conda activation code comes with the sandbox. 

We don't use condas for the mac builds and tests I believe, and this PR moves the PATH export to `.zshenv` for environment.

(This also reverts the PR: #30911) 

Signed-off-by: rickyyx <[email protected]>
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 16, 2023
@rickyyx @tamohannes
[ci] Fix issues with PS1 with conda activate (ray-project#30911)
9704221 
Signed-off-by: rickyyx <[email protected]>

With some searching, seems to be a similar issue (conda/conda#8186) with activating conda in bash script. However, it could also be unrelated. The major correlation is from where this error is thrown. I believe the error is raised when initializing conda when doing source ~/.zshrc, and we did change some of the scripting options in this PR(ray-project#27495) and its original revert.

So the hypothesis is because ci.sh changes some of the scripting options, and with &&, it also interferes with source ~/.zshrc which initializes conda.

Signed-off-by: tmynn <[email protected]>
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 16, 2023
@rickyyx @tamohannes
[all_tests][ci] Use .zshenv to avoid conda setting up breaks the pipe…
74f07d5 
…line (ray-project#30999)

We have seen mac wheel build failures like when setting up the environment. 

The error was raised when doing `source ~/.zshrc` which contains 
- an export PATH to include bazel that `ci.sh init` puts in
- default conda activation code comes with the sandbox. 

We don't use condas for the mac builds and tests I believe, and this PR moves the PATH export to `.zshenv` for environment.

(This also reverts the PR: ray-project#30911) 

Signed-off-by: rickyyx <[email protected]>
Signed-off-by: tmynn <[email protected]>
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
@rickyyx @tamohannes
[ci] Fix issues with PS1 with conda activate (ray-project#30911)
e02b11e 
Signed-off-by: rickyyx <[email protected]>

With some searching, seems to be a similar issue (conda/conda#8186) with activating conda in bash script. However, it could also be unrelated. The major correlation is from where this error is thrown. I believe the error is raised when initializing conda when doing source ~/.zshrc, and we did change some of the scripting options in this PR(ray-project#27495) and its original revert.

So the hypothesis is because ci.sh changes some of the scripting options, and with &&, it also interferes with source ~/.zshrc which initializes conda.

Signed-off-by: tmynn <[email protected]>
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
@rickyyx @tamohannes
[all_tests][ci] Use .zshenv to avoid conda setting up breaks the pipe…
1fb4670 
…line (ray-project#30999)

We have seen mac wheel build failures like when setting up the environment. 

The error was raised when doing `source ~/.zshrc` which contains 
- an export PATH to include bazel that `ci.sh init` puts in
- default conda activation code comes with the sandbox. 

We don't use condas for the mac builds and tests I believe, and this PR moves the PATH export to `.zshenv` for environment.

(This also reverts the PR: ray-project#30911) 

Signed-off-by: rickyyx <[email protected]>
Signed-off-by: tmynn <[email protected]>
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
@rickyyx @tamohannes
[ci] Fix issues with PS1 with conda activate (ray-project#30911)
4096012 
Signed-off-by: rickyyx <[email protected]>

With some searching, seems to be a similar issue (conda/conda#8186) with activating conda in bash script. However, it could also be unrelated. The major correlation is from where this error is thrown. I believe the error is raised when initializing conda when doing source ~/.zshrc, and we did change some of the scripting options in this PR(ray-project#27495) and its original revert.

So the hypothesis is because ci.sh changes some of the scripting options, and with &&, it also interferes with source ~/.zshrc which initializes conda.

Signed-off-by: tmynn <[email protected]>
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
@rickyyx @tamohannes
[all_tests][ci] Use .zshenv to avoid conda setting up breaks the pipe…
7a0a3ed 
…line (ray-project#30999)

We have seen mac wheel build failures like when setting up the environment. 

The error was raised when doing `source ~/.zshrc` which contains 
- an export PATH to include bazel that `ci.sh init` puts in
- default conda activation code comes with the sandbox. 

We don't use condas for the mac builds and tests I believe, and this PR moves the PATH export to `.zshenv` for environment.

(This also reverts the PR: ray-project#30911) 

Signed-off-by: rickyyx <[email protected]>
Signed-off-by: tmynn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krfricke krfricke krfricke approved these changes

@rkooo567 rkooo567 rkooo567 approved these changes

Assignees

@scv119 scv119

@krfricke krfricke

@rkooo567 rkooo567

@simon-mo simon-mo

Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@rickyyx @krfricke @rkooo567 @scv119 @simon-mo