Skip to content

Commit

Permalink
[ci] Fix issues with PS1 with conda activate (ray-project#30911)
Browse files Browse the repository at this point in the history
Signed-off-by: rickyyx <[email protected]>

With some searching, seems to be a similar issue (conda/conda#8186) with activating conda in bash script. However, it could also be unrelated. The major correlation is from where this error is thrown. I believe the error is raised when initializing conda when doing source ~/.zshrc, and we did change some of the scripting options in this PR(ray-project#27495) and its original revert.

So the hypothesis is because ci.sh changes some of the scripting options, and with &&, it also interferes with source ~/.zshrc which initializes conda.

Signed-off-by: Capiru <[email protected]>
  • Loading branch information
rickyyx authored and Capiru committed Dec 21, 2022
1 parent 4ae638c commit 73d3de0
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .buildkite/pipeline.macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ steps:
- export MAC_WHEELS=1
- export MAC_JARS=1
- export RAY_INSTALL_JAVA=1
- . ./ci/ci.sh init && source ~/.zshrc
- . ./ci/ci.sh init
- source ~/.zshrc
- ./ci/ci.sh build
# Test wheels
- ./ci/ci.sh test_wheels
Expand Down

0 comments on commit 73d3de0

Please sign in to comment.