Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci][core] bk:https://:mac: :apple: Wheels and Jars is flaky #30686

Closed
xwjiang2010 opened this issue Nov 28, 2022 · 6 comments · Fixed by #30911
Closed

[ci][core] bk:https://:mac: :apple: Wheels and Jars is flaky #30686

xwjiang2010 opened this issue Nov 28, 2022 · 6 comments · Fixed by #30911
Assignees
Labels
core Issues that should be addressed in Ray Core flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/

Comments

@xwjiang2010
Copy link
Contributor

on release branch:
https://buildkite.com/ray-project/oss-ci-build-branch/builds/1270#0184aa2f-4d93-4573-b67c-41a801f65913

on master:
https://buildkite.com/ray-project/oss-ci-build-branch/builds/1288#0184bdb3-96a6-44cf-a13b-03473f0a2c18

Seems to have the same signature with:
"/Users/ec2-user/.zshrc: line 77: PS1: unbound variable"

@xwjiang2010
Copy link
Contributor Author

My understanding is that this is not blocking release as the same failure happens for both master and release branch.
But want to confirm.

also cc @cadedaniel @clarence-wu who attempted to fix it before according to: https://anyscaleteam.slack.com/archives/CLJQR6420/p1667236766360979?thread_ts=1667235901.630159&cid=CLJQR6420

@xwjiang2010 xwjiang2010 added release-blocker P0 Issue that blocks the release core Issues that should be addressed in Ray Core r2.2-failure labels Nov 28, 2022
@cadedaniel
Copy link
Member

I don't think this should block release. I didn't follow the attempted fixes closely, @clarng can you confirm whether this should be release blocking or not?

@scv119 scv119 added P1 Issue that should be fixed within a few weeks release-blocker P0 Issue that blocks the release P0 Issues that should be fixed in short order and removed release-blocker P0 Issue that blocks the release r2.2-failure P1 Issue that should be fixed within a few weeks labels Nov 28, 2022
@scv119
Copy link
Contributor

scv119 commented Nov 28, 2022

@iycheng to decide if this is a release blocker.

@fishbone
Copy link
Contributor

@scv119 my feeling is that since it's not broken in ray 2.1 (https://buildkite.com/ray-project/oss-ci-build-branch/builds/1120#018486b8-ee35-4527-b2ce-140ae28678b5) and it seems that the whole test didn't run (2.1's run for 1-2 h and this only run for 30min). So we probably should fix this.

This one is the one creating wheels. If we skip this, I guess we won't have mac wheels.

@fishbone
Copy link
Contributor

fishbone commented Nov 29, 2022

Ok, it seems that it's just flakey. For example, https://buildkite.com/ray-project/oss-ci-build-branch/builds/1306#0184c097-232a-494c-b22d-ff393e946217 finished on releases 2.2.0 branch.

I'd say, if it's just flakey, it's not an issue. @xwjiang2010 when you get errors like this, could you just retry? If you successfully finish it eventually and get the wheels, I think it's OK. cc @scv119

@xwjiang2010
Copy link
Contributor Author

dropping release-blocker according to last comment.

@xwjiang2010 xwjiang2010 added flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/ and removed release-blocker P0 Issue that blocks the release P0 Issues that should be fixed in short order labels Nov 29, 2022
@rickyyx rickyyx self-assigned this Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues that should be addressed in Ray Core flaky-tracker Issue created via Flaky Test Tracker https://flaky-tests.ray.io/
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants