http3: pass tracing ID instead of quic.Connection to stream hijackers #4401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4401 +/- ##
==========================================
+ Coverage 84.88% 84.92% +0.04%
==========================================
Files 152 152
Lines 14342 14357 +15
==========================================
+ Hits 12174 12192 +18
+ Misses 1669 1666 -3
Partials 499 499 ☔ View full report in Codecov by Sentry. |
The stream hijackers only need to be able to associate the stream with the underlying QUIC connection. They are not supposed to call any functions on the quic.Connection. As such, the better API is to just pass them a unique identifier.
marten-seemann
force-pushed
the
http3-hijackers-connection-tracing-id
branch
from
0d62a15
to
11e0993
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #4400.The stream hijackers only need to be able to associate the stream with the underlying QUIC connection. They are not supposed to call any functions on the
quic.Connection. As such, the better API is to just pass them a unique identifier.This fixes a problem in webtransport-go introduced by #4389, where we're using a HTTP/3 connection, which, although satisfying the
quic.Connectioninterface, led to a type confusing.