introduce a ConnectionTracingID type for the ConnectionTracingKey #4400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a breaking API change. Unfortunately, context values are not strongly typed, so users will have have to take to change their type assertions.
marten-seemann
force-pushed
the
connection-tracing-id
branch
from
9492a9f
to
32f32df
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4400 +/- ##
=======================================
Coverage 84.90% 84.90%
=======================================
Files 152 152
Lines 14342 14342
=======================================
Hits 12177 12177
Misses 1666 1666
Partials 499 499 ☔ View full report in Codecov by Sentry. |
marten-seemann
commented
Apr 1, 2024
Comment on lines
60
to
+63
| var ConnectionTracingKey = connTracingCtxKey{} | ||
|
|
||
| // ConnectionTracingID is the type of the context value saved under the ConnectionTracingKey. | ||
| type ConnectionTracingID uint64 |
There was a problem hiding this comment.
I'm not really happy with the name. Tracing is an overloaded term, and we already used it for event tracer.
Any suggestions for a better name?
There was a problem hiding this comment.
I guess this is okay.
Other ideas that come to my mind are:
ConnectionTrackingID
ConnectionSeqID (as the id is sequential)
ConnectionName (used as a name for this connection in tracking)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking API change. Unfortunately, context values are not strongly typed, so users will have have to take care to change their type assertions.