http3: introduce a way for the server to query the client's SETTINGS #4389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The http.Request.Body can be type-asserted to a http3.Settingser. The Settings method on this interface blocks until the client's SETTINGS frame has been received.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4389 +/- ##
==========================================
+ Coverage 84.85% 84.88% +0.04%
==========================================
Files 152 152
Lines 14334 14342 +8
==========================================
+ Hits 12162 12174 +12
+ Misses 1672 1669 -3
+ Partials 500 499 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
http.Request.Bodycan be type-asserted to ahttp3.Settingser. TheSettingsmethod on this interface blocks until the client's SETTINGS frame has been received.Prerequisite for #3522.