Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New keyboard: Clueboard 2x1800 2019 #8721

Merged
merged 21 commits into from
May 6, 2020
Merged

Conversation

skullydazed
Copy link
Member

Description

Adds support for the Clueboard 2x1800 Mechanical Drawing Toy Edition.

Types of Changes

  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)

Checklist

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@skullydazed skullydazed requested a review from a team April 7, 2020 07:56
@skullydazed
Copy link
Member Author

This is a fixed up version of #5516, which I can't reopen after rebasing this branch and force pushing it.

keyboards/clueboard/2x1800/2019/config.h Outdated Show resolved Hide resolved
keyboards/clueboard/2x1800/2019/2019.c Outdated Show resolved Hide resolved
keyboards/clueboard/2x1800/2019/2019.c Outdated Show resolved Hide resolved
keyboards/clueboard/2x1800/2019/2019.c Outdated Show resolved Hide resolved
keyboards/clueboard/2x1800/2019/rules.mk Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team April 12, 2020 19:34
@drashna
Copy link
Member

drashna commented Apr 12, 2020

This is a fixed up version of #5516, which I can't reopen after rebasing this branch and force pushing it.

If you force pushed after closing the PR, yeah.... it won't let you re-open.

Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drashna drashna requested review from a team and fauxpark April 19, 2020 00:11
@skullydazed skullydazed requested review from fauxpark and a team April 30, 2020 00:33
@skullydazed skullydazed merged commit a30cc37 into master May 6, 2020
brandonschlack pushed a commit to brandonschlack/qmk_firmware that referenced this pull request May 7, 2020
* Initial support for the 2019 2x1800

* Get all hardware working.

* Fix shake to undo

* Use the method suggested by @reywood

* Remove the unnecessary for loop

* changes suggested by @noroadsleft

* Fix comma, period, and forward slash keys for clueboard 2x1800 default keymap by @reywood

* Call led_set_user at the end of led_set_kb (qmk#6265)

* [Keymap] Add default layouts for 2u spacebar (qmk#6266)

* make progress on drawing mode

* Finish drawing toy mode

* Update keyboards/clueboard/2x1800/2019/config.h

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* remove unnecessary files

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* apply suggestions

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

Co-authored-by: Sean Dwyer <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
* Initial support for the 2019 2x1800

* Get all hardware working.

* Fix shake to undo

* Use the method suggested by @reywood

* Remove the unnecessary for loop

* changes suggested by @noroadsleft

* Fix comma, period, and forward slash keys for clueboard 2x1800 default keymap by @reywood

* Call led_set_user at the end of led_set_kb (qmk#6265)

* [Keymap] Add default layouts for 2u spacebar (qmk#6266)

* make progress on drawing mode

* Finish drawing toy mode

* Update keyboards/clueboard/2x1800/2019/config.h

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* remove unnecessary files

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* apply suggestions

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

Co-authored-by: Sean Dwyer <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
* Initial support for the 2019 2x1800

* Get all hardware working.

* Fix shake to undo

* Use the method suggested by @reywood

* Remove the unnecessary for loop

* changes suggested by @noroadsleft

* Fix comma, period, and forward slash keys for clueboard 2x1800 default keymap by @reywood

* Call led_set_user at the end of led_set_kb (qmk#6265)

* [Keymap] Add default layouts for 2u spacebar (qmk#6266)

* make progress on drawing mode

* Finish drawing toy mode

* Update keyboards/clueboard/2x1800/2019/config.h

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* remove unnecessary files

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* apply suggestions

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

Co-authored-by: Sean Dwyer <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
* Initial support for the 2019 2x1800

* Get all hardware working.

* Fix shake to undo

* Use the method suggested by @reywood

* Remove the unnecessary for loop

* changes suggested by @noroadsleft

* Fix comma, period, and forward slash keys for clueboard 2x1800 default keymap by @reywood

* Call led_set_user at the end of led_set_kb (qmk#6265)

* [Keymap] Add default layouts for 2u spacebar (qmk#6266)

* make progress on drawing mode

* Finish drawing toy mode

* Update keyboards/clueboard/2x1800/2019/config.h

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* remove unnecessary files

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* apply suggestions

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

Co-authored-by: Sean Dwyer <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
* Initial support for the 2019 2x1800

* Get all hardware working.

* Fix shake to undo

* Use the method suggested by @reywood

* Remove the unnecessary for loop

* changes suggested by @noroadsleft

* Fix comma, period, and forward slash keys for clueboard 2x1800 default keymap by @reywood

* Call led_set_user at the end of led_set_kb (qmk#6265)

* [Keymap] Add default layouts for 2u spacebar (qmk#6266)

* make progress on drawing mode

* Finish drawing toy mode

* Update keyboards/clueboard/2x1800/2019/config.h

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* remove unnecessary files

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* apply suggestions

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

Co-authored-by: Sean Dwyer <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
@skullydazed skullydazed deleted the clueboard_2x1800_2019 branch August 18, 2020 05:09
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
* Initial support for the 2019 2x1800

* Get all hardware working.

* Fix shake to undo

* Use the method suggested by @reywood

* Remove the unnecessary for loop

* changes suggested by @noroadsleft

* Fix comma, period, and forward slash keys for clueboard 2x1800 default keymap by @reywood

* Call led_set_user at the end of led_set_kb (qmk#6265)

* [Keymap] Add default layouts for 2u spacebar (qmk#6266)

* make progress on drawing mode

* Finish drawing toy mode

* Update keyboards/clueboard/2x1800/2019/config.h

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* remove unnecessary files

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* apply suggestions

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

Co-authored-by: Sean Dwyer <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants