Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default layouts for 2u spacebar to Clueboard 2x1800 2019 #6266

Merged
merged 1 commit into from
Nov 21, 2019
Merged

Add default layouts for 2u spacebar to Clueboard 2x1800 2019 #6266

merged 1 commit into from
Nov 21, 2019

Conversation

reywood
Copy link
Contributor

@reywood reywood commented Jul 5, 2019

Add default ANSI and ISO layouts for 2u spacebar option. @skullydazed may want to review.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@reywood reywood changed the title Add default layouts for 2u spacebar Add default layouts for 2u spacebar to Clueboard 2x1800 2019 Jul 5, 2019
@drashna drashna requested a review from skullydazed July 6, 2019 06:18
@reywood
Copy link
Contributor Author

reywood commented Jul 8, 2019

I should have mentioned that I tested this on my 2x1800 that uses a 2u space bar, and everything appears to work.

@drashna drashna requested a review from a team July 30, 2019 08:14
noroadsleft
noroadsleft approved these changes Jul 30, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft requested a review from a team July 30, 2019 20:45
@yanfali
Copy link
Contributor

yanfali commented Jul 31, 2019

not sure the config.h files do anything really, so maybe just leave those out.

@reywood
Copy link
Contributor Author

reywood commented Jul 31, 2019

@yanfali I just copied the existing convention for this board. All the other keymaps have them.

@noroadsleft
Copy link
Member

@yanfali I think @skullydazed had the reasoning that the default keymaps should have no-change config.h and rules.mk files, so if a user ran the new keymap script, they'd have the files present in their keymap for making changes.

Perhaps a good idea in future would be to only include the files that are actually needed (so only keymap.c files on this PR), and then have the new keymap script check the default keymap folder for config.h and rules.mk files, and copy those if present, or the appropriate file from quantum/template/ if not.

drashna
drashna approved these changes Sep 21, 2019
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skullydazed any issues with this?

@stale
Copy link

stale bot commented Nov 20, 2019

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.

@stale stale bot removed the awaiting changes label Nov 21, 2019
@drashna drashna merged commit 9e1c291 into qmk:clueboard_2x1800_2019 Nov 21, 2019
skullydazed pushed a commit that referenced this pull request Feb 27, 2020
@reywood @skullydazed
[Keymap] Add default layouts for 2u spacebar (#6266)
b376037
skullydazed pushed a commit that referenced this pull request Apr 7, 2020
@reywood @skullydazed
[Keymap] Add default layouts for 2u spacebar (#6266)
c04fdb3
skullydazed added a commit that referenced this pull request May 6, 2020
@skullydazed @reywood
@drashna @fauxpark
New keyboard: Clueboard 2x1800 2019 (#8721)
a30cc37 
* Initial support for the 2019 2x1800

* Get all hardware working.

* Fix shake to undo

* Use the method suggested by @reywood

* Remove the unnecessary for loop

* changes suggested by @noroadsleft

* Fix comma, period, and forward slash keys for clueboard 2x1800 default keymap by @reywood

* Call led_set_user at the end of led_set_kb (#6265)

* [Keymap] Add default layouts for 2u spacebar (#6266)

* make progress on drawing mode

* Finish drawing toy mode

* Update keyboards/clueboard/2x1800/2019/config.h

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* remove unnecessary files

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* apply suggestions

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

Co-authored-by: Sean Dwyer <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
brandonschlack pushed a commit to brandonschlack/qmk_firmware that referenced this pull request May 7, 2020
@skullydazed @reywood
@drashna @fauxpark @brandonschlack
New keyboard: Clueboard 2x1800 2019 (qmk#8721)
c6e806f 
* Initial support for the 2019 2x1800

* Get all hardware working.

* Fix shake to undo

* Use the method suggested by @reywood

* Remove the unnecessary for loop

* changes suggested by @noroadsleft

* Fix comma, period, and forward slash keys for clueboard 2x1800 default keymap by @reywood

* Call led_set_user at the end of led_set_kb (qmk#6265)

* [Keymap] Add default layouts for 2u spacebar (qmk#6266)

* make progress on drawing mode

* Finish drawing toy mode

* Update keyboards/clueboard/2x1800/2019/config.h

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* remove unnecessary files

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* apply suggestions

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

Co-authored-by: Sean Dwyer <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@skullydazed @reywood
@drashna @fauxpark @lorenzoernesto
New keyboard: Clueboard 2x1800 2019 (qmk#8721)
8045f22 
* Initial support for the 2019 2x1800

* Get all hardware working.

* Fix shake to undo

* Use the method suggested by @reywood

* Remove the unnecessary for loop

* changes suggested by @noroadsleft

* Fix comma, period, and forward slash keys for clueboard 2x1800 default keymap by @reywood

* Call led_set_user at the end of led_set_kb (qmk#6265)

* [Keymap] Add default layouts for 2u spacebar (qmk#6266)

* make progress on drawing mode

* Finish drawing toy mode

* Update keyboards/clueboard/2x1800/2019/config.h

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* remove unnecessary files

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* apply suggestions

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

Co-authored-by: Sean Dwyer <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@skullydazed @reywood
@drashna @fauxpark @sowbug
New keyboard: Clueboard 2x1800 2019 (qmk#8721)
fad1e47 
* Initial support for the 2019 2x1800

* Get all hardware working.

* Fix shake to undo

* Use the method suggested by @reywood

* Remove the unnecessary for loop

* changes suggested by @noroadsleft

* Fix comma, period, and forward slash keys for clueboard 2x1800 default keymap by @reywood

* Call led_set_user at the end of led_set_kb (qmk#6265)

* [Keymap] Add default layouts for 2u spacebar (qmk#6266)

* make progress on drawing mode

* Finish drawing toy mode

* Update keyboards/clueboard/2x1800/2019/config.h

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* remove unnecessary files

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* apply suggestions

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

Co-authored-by: Sean Dwyer <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@skullydazed @reywood
@drashna @fauxpark @turky
New keyboard: Clueboard 2x1800 2019 (qmk#8721)
5637581 
* Initial support for the 2019 2x1800

* Get all hardware working.

* Fix shake to undo

* Use the method suggested by @reywood

* Remove the unnecessary for loop

* changes suggested by @noroadsleft

* Fix comma, period, and forward slash keys for clueboard 2x1800 default keymap by @reywood

* Call led_set_user at the end of led_set_kb (qmk#6265)

* [Keymap] Add default layouts for 2u spacebar (qmk#6266)

* make progress on drawing mode

* Finish drawing toy mode

* Update keyboards/clueboard/2x1800/2019/config.h

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* remove unnecessary files

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* apply suggestions

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

Co-authored-by: Sean Dwyer <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@skullydazed @reywood
@drashna @fauxpark @jakobaa
New keyboard: Clueboard 2x1800 2019 (qmk#8721)
8c3ca32 
* Initial support for the 2019 2x1800

* Get all hardware working.

* Fix shake to undo

* Use the method suggested by @reywood

* Remove the unnecessary for loop

* changes suggested by @noroadsleft

* Fix comma, period, and forward slash keys for clueboard 2x1800 default keymap by @reywood

* Call led_set_user at the end of led_set_kb (qmk#6265)

* [Keymap] Add default layouts for 2u spacebar (qmk#6266)

* make progress on drawing mode

* Finish drawing toy mode

* Update keyboards/clueboard/2x1800/2019/config.h

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* remove unnecessary files

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* apply suggestions

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

Co-authored-by: Sean Dwyer <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@skullydazed @reywood
@drashna @fauxpark @sjmacneil
New keyboard: Clueboard 2x1800 2019 (qmk#8721)
4fccb1a 
* Initial support for the 2019 2x1800

* Get all hardware working.

* Fix shake to undo

* Use the method suggested by @reywood

* Remove the unnecessary for loop

* changes suggested by @noroadsleft

* Fix comma, period, and forward slash keys for clueboard 2x1800 default keymap by @reywood

* Call led_set_user at the end of led_set_kb (qmk#6265)

* [Keymap] Add default layouts for 2u spacebar (qmk#6266)

* make progress on drawing mode

* Finish drawing toy mode

* Update keyboards/clueboard/2x1800/2019/config.h

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/2019.c

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Drashna Jaelre <[email protected]>

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* remove unnecessary files

* Update keyboards/clueboard/2x1800/2019/rules.mk

Co-Authored-By: Ryan <[email protected]>

* apply suggestions

* Apply suggestions from code review

Co-Authored-By: Ryan <[email protected]>

Co-authored-by: Sean Dwyer <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@noroadsleft noroadsleft noroadsleft approved these changes

@skullydazed skullydazed Awaiting requested review from skullydazed

Assignees
No one assigned
Labels
awaiting review keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reywood @yanfali @noroadsleft @drashna