Call led_set_user at the end of led_set_kb for Clueboard 2x1800 2019 #6265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@skullydazed may want to review |
fauxpark
approved these changes
Jul 6, 2019
drashna
approved these changes
Jul 6, 2019
noroadsleft
approved these changes
Jul 6, 2019
|
Thanks! |
skullydazed
pushed a commit
that referenced
this pull request
Feb 27, 2020
skullydazed
pushed a commit
that referenced
this pull request
Apr 7, 2020
skullydazed
added a commit
that referenced
this pull request
May 6, 2020
* Initial support for the 2019 2x1800 * Get all hardware working. * Fix shake to undo * Use the method suggested by @reywood * Remove the unnecessary for loop * changes suggested by @noroadsleft * Fix comma, period, and forward slash keys for clueboard 2x1800 default keymap by @reywood * Call led_set_user at the end of led_set_kb (#6265) * [Keymap] Add default layouts for 2u spacebar (#6266) * make progress on drawing mode * Finish drawing toy mode * Update keyboards/clueboard/2x1800/2019/config.h Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/2019.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/2019.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/2019.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/rules.mk Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/rules.mk Co-Authored-By: Ryan <[email protected]> * remove unnecessary files * Update keyboards/clueboard/2x1800/2019/rules.mk Co-Authored-By: Ryan <[email protected]> * apply suggestions * Apply suggestions from code review Co-Authored-By: Ryan <[email protected]> Co-authored-by: Sean Dwyer <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]>
brandonschlack
pushed a commit
to brandonschlack/qmk_firmware
that referenced
this pull request
May 7, 2020
* Initial support for the 2019 2x1800 * Get all hardware working. * Fix shake to undo * Use the method suggested by @reywood * Remove the unnecessary for loop * changes suggested by @noroadsleft * Fix comma, period, and forward slash keys for clueboard 2x1800 default keymap by @reywood * Call led_set_user at the end of led_set_kb (qmk#6265) * [Keymap] Add default layouts for 2u spacebar (qmk#6266) * make progress on drawing mode * Finish drawing toy mode * Update keyboards/clueboard/2x1800/2019/config.h Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/2019.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/2019.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/2019.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/rules.mk Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/rules.mk Co-Authored-By: Ryan <[email protected]> * remove unnecessary files * Update keyboards/clueboard/2x1800/2019/rules.mk Co-Authored-By: Ryan <[email protected]> * apply suggestions * Apply suggestions from code review Co-Authored-By: Ryan <[email protected]> Co-authored-by: Sean Dwyer <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]>
bitherder
pushed a commit
to bitherder/qmk_firmware
that referenced
this pull request
May 15, 2020
* Initial support for the 2019 2x1800 * Get all hardware working. * Fix shake to undo * Use the method suggested by @reywood * Remove the unnecessary for loop * changes suggested by @noroadsleft * Fix comma, period, and forward slash keys for clueboard 2x1800 default keymap by @reywood * Call led_set_user at the end of led_set_kb (qmk#6265) * [Keymap] Add default layouts for 2u spacebar (qmk#6266) * make progress on drawing mode * Finish drawing toy mode * Update keyboards/clueboard/2x1800/2019/config.h Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/2019.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/2019.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/2019.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/rules.mk Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/rules.mk Co-Authored-By: Ryan <[email protected]> * remove unnecessary files * Update keyboards/clueboard/2x1800/2019/rules.mk Co-Authored-By: Ryan <[email protected]> * apply suggestions * Apply suggestions from code review Co-Authored-By: Ryan <[email protected]> Co-authored-by: Sean Dwyer <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]>
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
May 24, 2020
* Initial support for the 2019 2x1800 * Get all hardware working. * Fix shake to undo * Use the method suggested by @reywood * Remove the unnecessary for loop * changes suggested by @noroadsleft * Fix comma, period, and forward slash keys for clueboard 2x1800 default keymap by @reywood * Call led_set_user at the end of led_set_kb (qmk#6265) * [Keymap] Add default layouts for 2u spacebar (qmk#6266) * make progress on drawing mode * Finish drawing toy mode * Update keyboards/clueboard/2x1800/2019/config.h Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/2019.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/2019.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/2019.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/rules.mk Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/rules.mk Co-Authored-By: Ryan <[email protected]> * remove unnecessary files * Update keyboards/clueboard/2x1800/2019/rules.mk Co-Authored-By: Ryan <[email protected]> * apply suggestions * Apply suggestions from code review Co-Authored-By: Ryan <[email protected]> Co-authored-by: Sean Dwyer <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]>
turky
pushed a commit
to turky/qmk_firmware
that referenced
this pull request
Jun 13, 2020
* Initial support for the 2019 2x1800 * Get all hardware working. * Fix shake to undo * Use the method suggested by @reywood * Remove the unnecessary for loop * changes suggested by @noroadsleft * Fix comma, period, and forward slash keys for clueboard 2x1800 default keymap by @reywood * Call led_set_user at the end of led_set_kb (qmk#6265) * [Keymap] Add default layouts for 2u spacebar (qmk#6266) * make progress on drawing mode * Finish drawing toy mode * Update keyboards/clueboard/2x1800/2019/config.h Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/2019.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/2019.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/2019.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/rules.mk Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/rules.mk Co-Authored-By: Ryan <[email protected]> * remove unnecessary files * Update keyboards/clueboard/2x1800/2019/rules.mk Co-Authored-By: Ryan <[email protected]> * apply suggestions * Apply suggestions from code review Co-Authored-By: Ryan <[email protected]> Co-authored-by: Sean Dwyer <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]>
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
* Initial support for the 2019 2x1800 * Get all hardware working. * Fix shake to undo * Use the method suggested by @reywood * Remove the unnecessary for loop * changes suggested by @noroadsleft * Fix comma, period, and forward slash keys for clueboard 2x1800 default keymap by @reywood * Call led_set_user at the end of led_set_kb (qmk#6265) * [Keymap] Add default layouts for 2u spacebar (qmk#6266) * make progress on drawing mode * Finish drawing toy mode * Update keyboards/clueboard/2x1800/2019/config.h Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/2019.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/2019.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/2019.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/rules.mk Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/rules.mk Co-Authored-By: Ryan <[email protected]> * remove unnecessary files * Update keyboards/clueboard/2x1800/2019/rules.mk Co-Authored-By: Ryan <[email protected]> * apply suggestions * Apply suggestions from code review Co-Authored-By: Ryan <[email protected]> Co-authored-by: Sean Dwyer <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]>
sjmacneil
pushed a commit
to sjmacneil/qmk_firmware
that referenced
this pull request
Feb 19, 2021
* Initial support for the 2019 2x1800 * Get all hardware working. * Fix shake to undo * Use the method suggested by @reywood * Remove the unnecessary for loop * changes suggested by @noroadsleft * Fix comma, period, and forward slash keys for clueboard 2x1800 default keymap by @reywood * Call led_set_user at the end of led_set_kb (qmk#6265) * [Keymap] Add default layouts for 2u spacebar (qmk#6266) * make progress on drawing mode * Finish drawing toy mode * Update keyboards/clueboard/2x1800/2019/config.h Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/2019.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/2019.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/2019.c Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/rules.mk Co-Authored-By: Drashna Jaelre <[email protected]> * Update keyboards/clueboard/2x1800/2019/rules.mk Co-Authored-By: Ryan <[email protected]> * remove unnecessary files * Update keyboards/clueboard/2x1800/2019/rules.mk Co-Authored-By: Ryan <[email protected]> * apply suggestions * Apply suggestions from code review Co-Authored-By: Ryan <[email protected]> Co-authored-by: Sean Dwyer <[email protected]> Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call led_set_user at the end of led_set_kb so that customizations can be made in keymaps.
Types of Changes
Checklist