Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update default h87a keymap for fn functionality #7589

Merged
merged 2 commits into from
Dec 9, 2019

Conversation

hineybush
Copy link
Contributor

@hineybush hineybush commented Dec 9, 2019

Description

Changes where the MO(1) layer switching key is to allow FN-layer switching if a user builds a 7u-based, blocked WKL keyboard with the default keymap's 6.25u-based bottom row.

Previous base keymap would prevent access to the FN layer as the default MO(1) key is the blocked one on this physical layout.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Previous base keymap would prevent access to the FN layer as the default MO(1) key is the blocked one on this physical layout.

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I think GitHub may be messing with me. I could have sworn the diff on the first commit was different than what it's now showing me.

Anyway, you fixed your issue. I'm not gonna be neurotic about white space right now.

@noroadsleft noroadsleft merged commit 9c6a752 into qmk:master Dec 9, 2019
@noroadsleft
Copy link
Member

Thanks!

patrl pushed a commit to patrl/qmk_firmware that referenced this pull request Dec 29, 2019
* update default h87a keymap for fn functionality

* Update keyboards/hineybush/h87a/keymaps/default/keymap.c
calmh added a commit to calmh/qmk_firmware that referenced this pull request Jan 17, 2020
* upstream/master: (1960 commits)
  [Keyboard] Think6.5 Default Keymap Cleanup (qmk#7594)
  [Keyboard] update m12og keymap to readable version (qmk#7581)
  [Keyboard] Add cKeys Washington keyboard (qmk#7570)
  [Keyboard] Fix 2U backspace key in ansi_blocker layout for GrayStudio Space65 keyboard (qmk#7593)
  [Keyboard] Remove `PREVENT_STUCK_MODIFIERS` from config.h files (qmk#7592)
  [Keyboard] update default h87a keymap for fn functionality (qmk#7589)
  [Keymap] ergotravel updates (qmk#7588)
  [Keyboard] Adjust ColorLice to work with QMK configurator (qmk#7572)
  [Keyboard] Adding Navi10 macropad (qmk#7556)
  Enable bitbang ws2812 for f4 (qmk#7571)
  [Keyboard] add Matrix 8XV1.2 og ISO/ANSI keyboard (qmk#7567)
  Also fix flash
  Fix compiling json files
  Add JSON keymap to prereq list of C keymap
  [Keyboard] instant60: Enable bootmagic lite to make eeprom reset easier (qmk#7566)
  Updated slave encoder sync to reduce dropped pulses - v2 (qmk#7505)
  [Keyboard] rebuild info.json for ep tf_longeboye (qmk#7560)
  [Keyboard] Added workaround for serial.c/LTO issue for helix/rev2 and helix/pico. (qmk#7558)
  [Keyboard] EP96: fix info.json key sequence (qmk#7557)
  [Keymap] Added my customized 40% layout (qmk#7555)
  ...
HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Feb 21, 2020
* update default h87a keymap for fn functionality

* Update keyboards/hineybush/h87a/keymaps/default/keymap.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants