Adding Navi10 macropad #7556
Merged
Adding Navi10 macropad #7556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fauxpark
requested changes
Dec 7, 2019
fauxpark
requested changes
Dec 7, 2019
fauxpark
approved these changes
Dec 8, 2019
drashna
reviewed
Dec 8, 2019
There was a problem hiding this comment.
I'm not a fan of having tapdance enabled in the default keymap. Even less so having it enabled "globally" via the keyboard's rules.mk file.
I'm not sure what the best solution would be, long term, but for now, could you move the TAP_DANCE_ENABLE = yes to a rules.mk file in the default keymap folder?
drashna
approved these changes
Dec 8, 2019
noroadsleft
approved these changes
Dec 9, 2019
|
Thanks! |
patrl
pushed a commit
to patrl/qmk_firmware
that referenced
this pull request
Dec 29, 2019
* working on keymap and files for the navi10 * fixing and modifying tap dance keys and layers * cleanup, and adding my separate keymap * edited and simplified the default keymap * cleaned up files and added support for future rev2 board * readme edits * moved rev0 specific keymap to it's own folder * added revision data to the config files * added DEFAULT_FOLDER * added note on compiling for a specific revision * documentation and readme edits * moved keymaps around and cleaned up * added photo * formatting and cleanup * fixing whitespace * moving the tap dance enable to keymap folders
calmh
added a commit
to calmh/qmk_firmware
that referenced
this pull request
Jan 17, 2020
* upstream/master: (1960 commits) [Keyboard] Think6.5 Default Keymap Cleanup (qmk#7594) [Keyboard] update m12og keymap to readable version (qmk#7581) [Keyboard] Add cKeys Washington keyboard (qmk#7570) [Keyboard] Fix 2U backspace key in ansi_blocker layout for GrayStudio Space65 keyboard (qmk#7593) [Keyboard] Remove `PREVENT_STUCK_MODIFIERS` from config.h files (qmk#7592) [Keyboard] update default h87a keymap for fn functionality (qmk#7589) [Keymap] ergotravel updates (qmk#7588) [Keyboard] Adjust ColorLice to work with QMK configurator (qmk#7572) [Keyboard] Adding Navi10 macropad (qmk#7556) Enable bitbang ws2812 for f4 (qmk#7571) [Keyboard] add Matrix 8XV1.2 og ISO/ANSI keyboard (qmk#7567) Also fix flash Fix compiling json files Add JSON keymap to prereq list of C keymap [Keyboard] instant60: Enable bootmagic lite to make eeprom reset easier (qmk#7566) Updated slave encoder sync to reduce dropped pulses - v2 (qmk#7505) [Keyboard] rebuild info.json for ep tf_longeboye (qmk#7560) [Keyboard] Added workaround for serial.c/LTO issue for helix/rev2 and helix/pico. (qmk#7558) [Keyboard] EP96: fix info.json key sequence (qmk#7557) [Keymap] Added my customized 40% layout (qmk#7555) ...
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Feb 21, 2020
* working on keymap and files for the navi10 * fixing and modifying tap dance keys and layers * cleanup, and adding my separate keymap * edited and simplified the default keymap * cleaned up files and added support for future rev2 board * readme edits * moved rev0 specific keymap to it's own folder * added revision data to the config files * added DEFAULT_FOLDER * added note on compiling for a specific revision * documentation and readme edits * moved keymaps around and cleaned up * added photo * formatting and cleanup * fixing whitespace * moving the tap dance enable to keymap folders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the Navi10 macropad to QMK.
Description
Adding my new macropad, the Navi10, to QMK.
Types of Changes
Issues Fixed or Closed by This PR
Checklist