Pti jc65 v32 a fix rgb backlight disable #6022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noroadsleft
reviewed
May 30, 2019
There was a problem hiding this comment.
Your JC65 changes look good. However, you have a new keyboard and four personal keymaps that are also in this pull request. Those sets of changes should be submitted in a separate pull request. (They can be submitted together, but they should be separate from the JC65 changes.)
eb540bf
to
6491b59
Compare
drashna
approved these changes
May 31, 2019
|
Oops, forgot about those. I’ll redo the PR.
Op do 30 mei 2019 om 20:39 schreef noroadsleft <[email protected]>
***@***.**** commented on this pull request.
Your JC65 changes look good. However, you have a new keyboard and four
personal keymaps that are also in this pull request. Those sets of changes
should be submitted in a separate pull request. (They can be submitted
together, but they should be separate from the JC65 changes.)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#6022?email_source=notifications&email_token=AAAK2MNO2Y4XSXAPUUTTE7TPYANMHA5CNFSM4HRHF74KYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2FIUPA#pullrequestreview-243960380>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAK2MOM673XSWJYNTC3CJTPYANMHANCNFSM4HRHF74A>
.
--
Sent from Gmail Mobile
|
|
@ptillemans #6025 is the only one that still needs attention, this one has been merged already. |
tenderlove
added a commit
to tenderlove/qmk_firmware
that referenced
this pull request
Jun 10, 2019
* master: (790 commits) [Keyboard] YMD96 refactor (qmk#5472) Update reference_configurator_support.md Use qmk docker image for travis CI builds [Keyboard] Remove file with same name and different case (qmk#6028) [Keyboard] Fix json for NK65 (qmk#6026) [Keymap] added hhkb layout for tada68 (qmk#6027) [Keymap] Added keymap for user jasondunsmore (qmk#6023) [Keyboard] Fix jc65 when RGB or BACKLIGHT disabled (qmk#6022) Update feature_encoders.md Copy avr teensy flash logic to arm (qmk#6016) [Keyboard] E6V2 R2 BMC PCB (qmk#6009) Add belgian layout for sendstring (qmk#6008) [Keyboard] Added XW60 PCB (qmk#6011) [Keymap] Georgi flippydippy layout (qmk#6005) Fix TO() and DF() calling layer_state_set_[kb,user] twice (qmk#6003) Update 333fred keymaps and add new iris map. (qmk#6010) [Keyboard] Changed LED positions for Massdrop CTRL and DZ60RGB (qmk#5801) [Keyboard] Add support for AKB boards (qmk#5996) Duck Octagon V1 Configurator cleanup (qmk#5957) Fixing matrix_scan so it properly returns changed status ...
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
kimat
pushed a commit
to kimat/qmk_firmware
that referenced
this pull request
Sep 8, 2019
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
JeffreyPalmer
pushed a commit
to JeffreyPalmer/qmk_firmware
that referenced
this pull request
Feb 27, 2020
swamp09
pushed a commit
to swamp09/qmk_firmware
that referenced
this pull request
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When building a firmware with RGB and Backlight disabled there were compile errors
because the headers are not imported but the code which calls its methods are still
called.
This change adds additional #ifdefs to remove the problematic pieces.
Types of Changes
Issues Fixed or Closed by This PR
Checklist