Fix TO() and DF() calling layer_state_set_[kb,user] twice #6003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
May 28, 2019
drashna
requested review from
algernon,
fredizzimo,
jackhumbert,
mechmerlin,
noroadsleft,
skullydazed and
yanfali
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
May 29, 2019
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jun 4, 2019
tenderlove
added a commit
to tenderlove/qmk_firmware
that referenced
this pull request
Jun 10, 2019
* master: (790 commits) [Keyboard] YMD96 refactor (qmk#5472) Update reference_configurator_support.md Use qmk docker image for travis CI builds [Keyboard] Remove file with same name and different case (qmk#6028) [Keyboard] Fix json for NK65 (qmk#6026) [Keymap] added hhkb layout for tada68 (qmk#6027) [Keymap] Added keymap for user jasondunsmore (qmk#6023) [Keyboard] Fix jc65 when RGB or BACKLIGHT disabled (qmk#6022) Update feature_encoders.md Copy avr teensy flash logic to arm (qmk#6016) [Keyboard] E6V2 R2 BMC PCB (qmk#6009) Add belgian layout for sendstring (qmk#6008) [Keyboard] Added XW60 PCB (qmk#6011) [Keymap] Georgi flippydippy layout (qmk#6005) Fix TO() and DF() calling layer_state_set_[kb,user] twice (qmk#6003) Update 333fred keymaps and add new iris map. (qmk#6010) [Keyboard] Changed LED positions for Massdrop CTRL and DZ60RGB (qmk#5801) [Keyboard] Add support for AKB boards (qmk#5996) Duck Octagon V1 Configurator cleanup (qmk#5957) Fixing matrix_scan so it properly returns changed status ...
Timbus
pushed a commit
to Timbus/qmk_firmware
that referenced
this pull request
Jun 23, 2019
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
JeffreyPalmer
pushed a commit
to JeffreyPalmer/qmk_firmware
that referenced
this pull request
Feb 27, 2020
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
TO()andDF(),layer_state_set_user()was observed to be called twice. This was not a keydown/keyup thing - the code first does anAND, then anOR, which both calllayer_state_set(), which in turn callslayer_state_set_kb()... Instead of doing that, we can directly set the layer state here.Types of Changes
Issues Fixed or Closed by This PR
Checklist