Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YMD96 refactor #5472

Merged
merged 8 commits into from
May 31, 2019
Merged

YMD96 refactor #5472

merged 8 commits into from
May 31, 2019

Conversation

noroadsleft
Copy link
Member

Goal: bringing the YMD96 codebase up to modern standards and add layout support to QMK Configurator.

@noroadsleft
Copy link
Member Author

@harshitgoel96 Near as I can tell, your keymap (as it's checked in to QMK's master) doesn't have any way to access the _RAISE layer. You have a keycode assigned for it, but it seems the layout macro locks it to KC_NO.

Please advise/clarify whether this is the case. I don't have any intentions of modifying user keymaps here more than necessary, but I'd like to get rid of the KC_NO on the KEYMAP_CUSTOM/now LAYOUT_custom macro - it's relevant to the Configurator's support for the board - but if I do that, your keymap will break.

@harshitgoel96
Copy link
Contributor

harshitgoel96 commented Mar 23, 2019 via email

@noroadsleft
Copy link
Member Author

Thanks for the prompt reply. Sorry to hear your health has been poor.

I obviously forgot you had a PR open for this. (I commented several times! 🤦‍♂️ )

If you'd like, I'll close this, or reduce the scope of this PR. You were the first one to these changes, so I'll leave the decision to you.

@harshitgoel96
Copy link
Contributor

harshitgoel96 commented Mar 24, 2019 via email

@harshitgoel96
Copy link
Contributor

Hi, I have updated the PR with suggested changes. Can you please check the PR #4982 , and adjust the scope for this PR ?

@noroadsleft
Copy link
Member Author

Left a review on your PR; will place this PR on-hold until yours is merged, so I can integrate your changes cleanly.

@noroadsleft noroadsleft changed the title [WIP] YMD96 refactor and Configurator support [WIP; On Hold] YMD96 refactor Mar 24, 2019
@noroadsleft noroadsleft changed the title [WIP; On Hold] YMD96 refactor [WIP] YMD96 refactor May 15, 2019
@noroadsleft
Rename layers enum and default layer
46a28e7 
- renamed layers enum to layer_names
  - proposed by fauxpark in Issue 5977, and I like the idea
    - qmk#5977 (comment)
- renamed the base layer to _DEFAULT
  - I think it looks nicer.
@noroadsleft noroadsleft changed the title [WIP] YMD96 refactor YMD96 refactor May 29, 2019
@noroadsleft
Copy link
Member Author

This PR is ready... except I have no idea why Travis is suddenly failing.

@drashna
Copy link
Member

drashna commented May 31, 2019

Thanks!

@drashna drashna merged commit 2a1f638 into qmk:master May 31, 2019
@noroadsleft noroadsleft deleted the cf/ymd96 branch May 31, 2019 19:09
tenderlove added a commit to tenderlove/qmk_firmware that referenced this pull request Jun 10, 2019
@tenderlove
Merge branch 'master' into merging
a1a19e0 
* master: (790 commits)
  [Keyboard] YMD96 refactor (qmk#5472)
  Update reference_configurator_support.md
  Use qmk docker image for travis CI builds
  [Keyboard] Remove file with same name and different case (qmk#6028)
  [Keyboard] Fix json for NK65 (qmk#6026)
  [Keymap] added hhkb layout for tada68 (qmk#6027)
  [Keymap] Added keymap for user jasondunsmore (qmk#6023)
  [Keyboard] Fix jc65 when RGB or BACKLIGHT disabled (qmk#6022)
  Update feature_encoders.md
  Copy avr teensy flash logic to arm (qmk#6016)
  [Keyboard] E6V2 R2 BMC PCB (qmk#6009)
  Add belgian layout for sendstring (qmk#6008)
  [Keyboard] Added XW60 PCB (qmk#6011)
  [Keymap] Georgi flippydippy layout (qmk#6005)
  Fix TO() and DF() calling layer_state_set_[kb,user] twice (qmk#6003)
  Update 333fred keymaps and add new iris map. (qmk#6010)
  [Keyboard] Changed LED positions for Massdrop CTRL and DZ60RGB (qmk#5801)
  [Keyboard] Add support for AKB boards (qmk#5996)
  Duck Octagon V1 Configurator cleanup (qmk#5957)
  Fixing matrix_scan so it properly returns changed status
  ...
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@noroadsleft @Timbus
[Keyboard] YMD96 refactor (qmk#5472)
e293f63 
* Remove JJ50 data from YMD96

JJ50 was actually added as its own keyboard when this was added in qmk#2546. It should have been taken out then, but wasn't.

* Update ymd96.h

- use #pragma once include guard
- remove redundant file includes

* Update LAYOUT_iso macro to K<row><col> notation

* Update LAYOUT_custom macro to K<row><col> notation

* Update LAYOUT_default macro to K<row><col> notation

* Refactor default keymap

* Rename readme file to lowercase

* Rename layers enum and default layer

- renamed layers enum to layer_names
  - proposed by fauxpark in Issue 5977, and I like the idea
    - qmk#5977 (comment)
- renamed the base layer to _DEFAULT
  - I think it looks nicer.
kimat pushed a commit to kimat/qmk_firmware that referenced this pull request Sep 8, 2019
@noroadsleft @kimat
[Keyboard] YMD96 refactor (qmk#5472)
e7fd5ff 
* Remove JJ50 data from YMD96

JJ50 was actually added as its own keyboard when this was added in qmk#2546. It should have been taken out then, but wasn't.

* Update ymd96.h

- use #pragma once include guard
- remove redundant file includes

* Update LAYOUT_iso macro to K<row><col> notation

* Update LAYOUT_custom macro to K<row><col> notation

* Update LAYOUT_default macro to K<row><col> notation

* Refactor default keymap

* Rename readme file to lowercase

* Rename layers enum and default layer

- renamed layers enum to layer_names
  - proposed by fauxpark in Issue 5977, and I like the idea
    - qmk#5977 (comment)
- renamed the base layer to _DEFAULT
  - I think it looks nicer.
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
@noroadsleft @drashna
[Keyboard] YMD96 refactor (qmk#5472)
5000b3d 
* Remove JJ50 data from YMD96

JJ50 was actually added as its own keyboard when this was added in qmk#2546. It should have been taken out then, but wasn't.

* Update ymd96.h

- use #pragma once include guard
- remove redundant file includes

* Update LAYOUT_iso macro to K<row><col> notation

* Update LAYOUT_custom macro to K<row><col> notation

* Update LAYOUT_default macro to K<row><col> notation

* Refactor default keymap

* Rename readme file to lowercase

* Rename layers enum and default layer

- renamed layers enum to layer_names
  - proposed by fauxpark in Issue 5977, and I like the idea
    - qmk#5977 (comment)
- renamed the base layer to _DEFAULT
  - I think it looks nicer.
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
@noroadsleft @JeffreyPalmer
[Keyboard] YMD96 refactor (qmk#5472)
6261002 
* Remove JJ50 data from YMD96

JJ50 was actually added as its own keyboard when this was added in qmk#2546. It should have been taken out then, but wasn't.

* Update ymd96.h

- use #pragma once include guard
- remove redundant file includes

* Update LAYOUT_iso macro to K<row><col> notation

* Update LAYOUT_custom macro to K<row><col> notation

* Update LAYOUT_default macro to K<row><col> notation

* Refactor default keymap

* Rename readme file to lowercase

* Rename layers enum and default layer

- renamed layers enum to layer_names
  - proposed by fauxpark in Issue 5977, and I like the idea
    - qmk#5977 (comment)
- renamed the base layer to _DEFAULT
  - I think it looks nicer.
swamp09 pushed a commit to swamp09/qmk_firmware that referenced this pull request Mar 11, 2020
@noroadsleft @swamp09
[Keyboard] YMD96 refactor (qmk#5472)
5873a62 
* Remove JJ50 data from YMD96

JJ50 was actually added as its own keyboard when this was added in qmk#2546. It should have been taken out then, but wasn't.

* Update ymd96.h

- use #pragma once include guard
- remove redundant file includes

* Update LAYOUT_iso macro to K<row><col> notation

* Update LAYOUT_custom macro to K<row><col> notation

* Update LAYOUT_default macro to K<row><col> notation

* Refactor default keymap

* Rename readme file to lowercase

* Rename layers enum and default layer

- renamed layers enum to layer_names
  - proposed by fauxpark in Issue 5977, and I like the idea
    - qmk#5977 (comment)
- renamed the base layer to _DEFAULT
  - I think it looks nicer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
duplicate keyboard on hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@noroadsleft @harshitgoel96 @drashna