-
Notifications
You must be signed in to change notification settings - Fork 22k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BE] enable UFMT for torch/storage.py
#127706
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127706
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit f68236f with merge base 5ee893a (): NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jun 2, 2024
XuehaiPan
added
better-engineering
Relatively self-contained tasks for better engineering contributors
topic: not user facing
topic category
module: lint
Issues related to our Python/C++ lint rules (run by Travis)
labels
Jun 2, 2024
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jun 17, 2024
ghstack-source-id: 22b40daa38307c5ba2f734ad1654c44239698db6 Pull Request resolved: pytorch#127706
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jun 24, 2024
ghstack-source-id: 413802306fe6d86ec9f393d1fbd3867f8742a8c1 Pull Request resolved: pytorch#127706
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jun 24, 2024
ghstack-source-id: 313255f727242b12d25867329e4f9bb6a40d6a00 Pull Request resolved: pytorch#127706
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jun 25, 2024
ghstack-source-id: f0940f154696eb0b2eaad7c0e30990e3280f680a Pull Request resolved: pytorch#127706
ezyang
approved these changes
Jun 27, 2024
XuehaiPan
added a commit
to XuehaiPan/pytorch
that referenced
this pull request
Jun 27, 2024
ghstack-source-id: 697b187746a452de37c26467fd9a18822262b2fb Pull Request resolved: pytorch#127706
pytorchmergebot
pushed a commit
that referenced
this pull request
Jun 27, 2024
Pull Request resolved: #127704 Approved by: https://github.com/ezyang ghstack dependencies: #127706
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
better-engineering
Relatively self-contained tasks for better engineering contributors
ciflow/inductor
ciflow/trunk
Trigger trunk jobs on your pull request
Merged
module: amp (automated mixed precision)
autocast
module: inductor
module: lint
Issues related to our Python/C++ lint rules (run by Travis)
open source
suppress-bc-linter
Suppresses the failures of API backward-compatibility linter (Lint/bc_linter)
topic: not user facing
topic category
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
torch.autograd
andtorch.nn.parameter
#128633torch/nn/
#128865torch.utils.data
#127705torch.utils.data
#127704torch/storage.py
#127706Part of #123062
cc @mcarilli @ptrblck @leslie-fang-intel @jgong5 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @peterbell10 @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang