Resolve circular dependence between `torch.autograd` and `torch.nn.parameter` #128633

XuehaiPan · 2024-06-13T18:26:57Z

Stack from ghstack (oldest at bottom):

This PR changes the reference to torch.nn.parameter.Parameter in C++ code to torch._parameter.Parameter (they are the same object) after #130327.

pytorch/torch/csrc/autograd/init.cpp

Lines 123 to 131 in a5f816d

 auto parameter_module = 

 THPObjectPtr(PyImport_ImportModule("torch.nn.parameter")); 

 if (!parameter_module) 

 return nullptr; 

 // NOTE: "leaks" ParameterClass 

 ParameterClass = PyObject_GetAttrString(parameter_module, "Parameter"); 

 if (!ParameterClass) 

 return nullptr;

Closes #128609

cc @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @osalpekar @jiayisuse @H-Huang @kwen2501 @awgu @fegin @XilunWu @wanchaol @fduwjj @wz337 @wconstab @chauhang @d4l3k @ezyang @albanD @pearu @nikitaved @soulitzer @Varal7 @mruberry @jbschlosser @walterddr @mikaylagawarecki @penguinwu @tianyu-l @yf225 @lezcano

[ghstack-poisoned]

pytorch-bot · 2024-06-13T18:27:00Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128633

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

❌ 104 New Failures, 3 Unrelated Failures

As of commit 7f7fd30 with merge base 500aea8 ():

NEW FAILURES - The following jobs have failed:

BC Lint / bc_linter (gh)
Process completed with exit code 1.
Lint / lintrunner-noclang / linux-job (gh)
>>> Lint for torch/distributed/utils.py:
linux-binary-manywheel / manywheel-py3_8-cuda11_8-split-test / test (gh)
Process completed with exit code 1.
linux-binary-manywheel / manywheel-py3_8-cuda11_8-test / test (gh)
Process completed with exit code 1.
linux-binary-manywheel / manywheel-py3_8-cuda12_1-split-test / test (gh)
Process completed with exit code 1.
linux-binary-manywheel / manywheel-py3_8-cuda12_1-test / test (gh)
Process completed with exit code 1.
linux-binary-manywheel / manywheel-py3_8-cuda12_4-split-test / test (gh)
Process completed with exit code 1.
linux-binary-manywheel / manywheel-py3_8-cuda12_4-test / test (gh)
Process completed with exit code 1.
pull / linux-docs / build-docs-functorch-false (gh)
Process completed with exit code 2.
pull / linux-docs / build-docs-python-false (gh)
Process completed with exit code 2.
pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 1, 3, linux.8xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 2, 3, linux.8xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
pull / linux-focal-cuda11.8-py3.10-gcc9 / test (distributed, 3, 3, linux.8xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 1, 5, amz2023.linux.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 2, 5, amz2023.linux.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 3, 5, amz2023.linux.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 4, 5, amz2023.linux.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
pull / linux-focal-cuda12.1-py3.10-gcc9 / test (default, 5, 5, amz2023.linux.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
pull / linux-focal-cuda12.1-py3.10-gcc9-bazel-test / build-and-test (default, 1, 1, amz2023.linux.4xlarge.nvidia.gpu) (gh)
Build completed, 1 test FAILED, 3201 total actions
pull / linux-focal-cuda12.1-py3.10-gcc9-experimental-split-build / test (default, 1, 5, amz2023.linux.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
pull / linux-focal-cuda12.1-py3.10-gcc9-experimental-split-build / test (default, 2, 5, amz2023.linux.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
pull / linux-focal-cuda12.1-py3.10-gcc9-experimental-split-build / test (default, 3, 5, amz2023.linux.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
pull / linux-focal-cuda12.1-py3.10-gcc9-experimental-split-build / test (default, 4, 5, amz2023.linux.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
pull / linux-focal-cuda12.1-py3.10-gcc9-experimental-split-build / test (default, 5, 5, amz2023.linux.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 1, 5, amz2023.linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 2, 5, amz2023.linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 3, 5, amz2023.linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 4, 5, amz2023.linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
pull / linux-focal-cuda12.1-py3.10-gcc9-sm86 / test (default, 5, 5, amz2023.linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
pull / linux-focal-cuda12.4-py3.10-gcc9-bazel-test / build-and-test (default, 1, 1, amz2023.linux.4xlarge.nvidia.gpu) (gh)
Build completed, 1 test FAILED, 3203 total actions
pull / linux-focal-py3_8-clang9-xla / test (xla, 1, 1, amz2023.linux.12xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.11-clang10 / test (crossref, 1, 2, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.11-clang10 / test (crossref, 2, 2, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.11-clang10 / test (default, 1, 4, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.11-clang10 / test (default, 2, 4, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.11-clang10 / test (default, 3, 4, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.11-clang10 / test (default, 4, 4, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.11-clang10 / test (dynamo, 1, 3, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.11-clang10 / test (dynamo, 2, 3, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.11-clang10 / test (dynamo, 3, 3, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.12-clang10 / test (default, 1, 4, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.12-clang10 / test (default, 2, 4, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.12-clang10 / test (default, 3, 4, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.12-clang10 / test (default, 4, 4, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.12-clang10 / test (dynamo, 1, 3, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.12-clang10 / test (dynamo, 2, 3, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.12-clang10 / test (dynamo, 3, 3, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.12-clang10-experimental-split-build / test (default, 1, 3, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.12-clang10-experimental-split-build / test (default, 2, 3, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.12-clang10-experimental-split-build / test (default, 3, 3, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.12-clang10-experimental-split-build / test (dynamo, 1, 3, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.12-clang10-experimental-split-build / test (dynamo, 2, 3, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.12-clang10-experimental-split-build / test (dynamo, 3, 3, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.8-clang10 / test (crossref, 1, 2, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.8-clang10 / test (crossref, 2, 2, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.8-clang10 / test (default, 1, 4, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.8-clang10 / test (default, 2, 4, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.8-clang10 / test (default, 3, 4, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.8-clang10 / test (default, 4, 4, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.8-clang10 / test (dynamo, 1, 3, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.8-clang10 / test (dynamo, 2, 3, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.8-clang10 / test (dynamo, 3, 3, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.8-clang10-onnx / test (default, 1, 2, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-focal-py3.8-clang10-onnx / test (default, 2, 2, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-jammy-py3.10-clang15-asan / test (default, 1, 6, amz2023.linux.4xlarge) (gh)
Process completed with exit code 1.
pull / linux-jammy-py3.10-clang15-asan / test (default, 2, 6, amz2023.linux.4xlarge) (gh)
Process completed with exit code 1.
pull / linux-jammy-py3.10-clang15-asan / test (default, 3, 6, amz2023.linux.4xlarge) (gh)
Process completed with exit code 1.
pull / linux-jammy-py3.10-clang15-asan / test (default, 4, 6, amz2023.linux.4xlarge) (gh)
Process completed with exit code 1.
pull / linux-jammy-py3.10-clang15-asan / test (default, 5, 6, amz2023.linux.4xlarge) (gh)
Process completed with exit code 1.
pull / linux-jammy-py3.10-clang15-asan / test (default, 6, 6, amz2023.linux.4xlarge) (gh)
Process completed with exit code 1.
pull / linux-jammy-py3.8-gcc11 / test (backwards_compat, 1, 1, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-jammy-py3.8-gcc11 / test (default, 1, 4, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-jammy-py3.8-gcc11 / test (default, 2, 4, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-jammy-py3.8-gcc11 / test (default, 3, 4, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-jammy-py3.8-gcc11 / test (default, 4, 4, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-jammy-py3.8-gcc11 / test (distributed, 1, 2, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-jammy-py3.8-gcc11 / test (distributed, 2, 2, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-jammy-py3.8-gcc11 / test (docs_test, 1, 1, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
pull / linux-jammy-py3.8-gcc11 / test (jit_legacy, 1, 1, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (default, 1, 5, amz2023.linux.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (default, 2, 5, amz2023.linux.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (default, 3, 5, amz2023.linux.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (default, 4, 5, amz2023.linux.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (default, 5, 5, amz2023.linux.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (jit_legacy, 1, 1, amz2023.linux.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (nogpu_AVX512, 1, 1, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
trunk / linux-focal-cuda12.4-py3.10-gcc9-experimental-split-build-test / test (nogpu_NO_AVX2, 1, 1, amz2023.linux.2xlarge) (gh)
Process completed with exit code 1.
trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 1, 5, amz2023.linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 2, 5, amz2023.linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 3, 5, amz2023.linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 4, 5, amz2023.linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
trunk / linux-focal-cuda12.4-py3.10-gcc9-sm86 / test (default, 5, 5, amz2023.linux.g5.4xlarge.nvidia.gpu) (gh)
Process completed with exit code 1.
trunk / linux-focal-rocm6.1-py3.8 / test (default, 1, 2, linux.rocm.gpu) (gh)
Process completed with exit code 1.
trunk / linux-focal-rocm6.1-py3.8 / test (default, 2, 2, linux.rocm.gpu) (gh)
Process completed with exit code 1.
trunk / linux-focal-rocm6.1-py3.8 / test (distributed, 1, 1, linux.rocm.gpu) (gh)
Process completed with exit code 1.
trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable) (gh)
ImportError: cannot import name '_maybe_get_opdef' from partially initialized module 'torch._library.custom_ops' (most likely due to a circular import) (/Users/ec2-user/runner/_work/_temp/conda_environment_10138095330/lib/python3.9/site-packages/torch/_library/custom_ops.py)
trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable) (gh)
ImportError: cannot import name '_maybe_get_opdef' from partially initialized module 'torch._library.custom_ops' (most likely due to a circular import) (/Users/ec2-user/runner/_work/_temp/conda_environment_10138095330/lib/python3.9/site-packages/torch/_library/custom_ops.py)
trunk / macos-py3-arm64 / test (default, 3, 3, macos-m1-stable) (gh)
ImportError: cannot import name '_maybe_get_opdef' from partially initialized module 'torch._library.custom_ops' (most likely due to a circular import) (/Users/ec2-user/runner/_work/_temp/conda_environment_10138095330/lib/python3.9/site-packages/torch/_library/custom_ops.py)
trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-13) (gh)
ImportError: cannot import name '_maybe_get_opdef' from partially initialized module 'torch._library.custom_ops' (most likely due to a circular import) (/Users/ec2-user/runner/_work/_temp/conda_environment_10138095330/lib/python3.9/site-packages/torch/_library/custom_ops.py)
trunk / macos-py3-arm64-mps / test (mps, 1, 1, macos-m1-14) (gh)
ImportError: cannot import name '_maybe_get_opdef' from partially initialized module 'torch._library.custom_ops' (most likely due to a circular import) (/Users/ec2-user/runner/_work/_temp/conda_environment_10138095330/lib/python3.9/site-packages/torch/_library/custom_ops.py)
trunk / win-vs2019-cpu-py3 / test (default, 1, 3, windows.4xlarge.nonephemeral) (gh)
Process completed with exit code 1.
trunk / win-vs2019-cpu-py3 / test (default, 2, 3, windows.4xlarge.nonephemeral) (gh)
Process completed with exit code 1.
trunk / win-vs2019-cpu-py3 / test (default, 3, 3, windows.4xlarge.nonephemeral) (gh)
Process completed with exit code 1.

UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:

trunk / linux-focal-cuda11.8-py3.10-gcc9-experimental-split-build-test / test (distributed, 1, 3, linux.8xlarge.nvidia.gpu) (gh) (#129539)
Process completed with exit code 1.
trunk / linux-focal-cuda11.8-py3.10-gcc9-experimental-split-build-test / test (distributed, 2, 3, linux.8xlarge.nvidia.gpu) (gh) (#129539)
Process completed with exit code 1.
trunk / linux-focal-cuda11.8-py3.10-gcc9-experimental-split-build-test / test (distributed, 3, 3, linux.8xlarge.nvidia.gpu) (gh) (#129539)
Process completed with exit code 1.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

…rameter` ghstack-source-id: 8da14380554e114dada41e19658aae1cf0dcc1b2 Pull Request resolved: #128633

[ghstack-poisoned]

…rameter` ghstack-source-id: 5816f1cb0f8bcca3b4639d7002394e8ad65b2fe1 Pull Request resolved: #128633

[ghstack-poisoned]

…rameter` ghstack-source-id: 9ec03f6ecf8468f0f2b692e4797ca5bc219e9223 Pull Request resolved: #128633

…rameter` ghstack-source-id: adc22398c2d5d5f9fbd98d19ace7721313bc1c1a Pull Request resolved: #128633

[ghstack-poisoned]

…rameter` ghstack-source-id: e8977d062f9af4dd38f5c8ae5da6e00454cb52ed Pull Request resolved: #128633

[ghstack-poisoned]

…rameter` ghstack-source-id: 2cc2999a6eaf6b3e95396af8a2c08ad200ca15d8 Pull Request resolved: #128633

[ghstack-poisoned]

…rameter` ghstack-source-id: 8c1cd943a21d2acbc72b249b1feac4091871ff86 Pull Request resolved: #128633

[ghstack-poisoned]

…rameter` ghstack-source-id: c50623300c2d1b24116c61bf8a4b7350b3d5d00b Pull Request resolved: #128633

[ghstack-poisoned]

…rameter` ghstack-source-id: 957d639897b6ae381076395a17ab7773a693dcc2 Pull Request resolved: #128633

Split from #128633. - #128633 Move commonly used functions (e.g. `is_scripting`) to the top of the module to avoid circular dependency. Pull Request resolved: #130531 Approved by: https://github.com/EikanWang, https://github.com/ezyang

Update

891d98d

[ghstack-poisoned]

XuehaiPan requested review from andrewkho, gokulavasan, lezcano, albanD, jbschlosser, mikaylagawarecki and soulitzer as code owners June 13, 2024 18:26

XuehaiPan mentioned this pull request Jun 13, 2024

[BE] enable UFMT for torch/nn/utils #128595

Closed

XuehaiPan mentioned this pull request Jun 13, 2024

[BE][Easy] enable UFMT for torch/nn/parallel #128596

Closed

pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category labels Jun 13, 2024

This was referenced Jun 13, 2024

[BE] enable UFMT for torch/nn/modules #128594

Closed

[BE] enable UFMT for torch/nn/functional.py #128592

Closed

[BE] enable UFMT for torch/nn/*.py #128593

Closed

XuehaiPan marked this pull request as draft June 13, 2024 18:27

XuehaiPan added the module: autograd Related to torch.autograd, and the autograd engine in general label Jun 13, 2024

pytorchbot added the open source label Jun 13, 2024

Update

70e5378

[ghstack-poisoned]

Update

2a014c7

[ghstack-poisoned]

XuehaiPan added a commit that referenced this pull request Jun 13, 2024

Resolve circular dependence between torch.autograd and `torch.nn.pa…

af9a429

…rameter` ghstack-source-id: 8da14380554e114dada41e19658aae1cf0dcc1b2 Pull Request resolved: #128633

Update

020cc3d

[ghstack-poisoned]

XuehaiPan added a commit that referenced this pull request Jun 14, 2024

Resolve circular dependence between torch.autograd and `torch.nn.pa…

6002dad

…rameter` ghstack-source-id: 5816f1cb0f8bcca3b4639d7002394e8ad65b2fe1 Pull Request resolved: #128633

Update

5efb1f0

[ghstack-poisoned]

XuehaiPan added a commit that referenced this pull request Jun 16, 2024

Resolve circular dependence between torch.autograd and `torch.nn.pa…

25a1e24

…rameter` ghstack-source-id: 9ec03f6ecf8468f0f2b692e4797ca5bc219e9223 Pull Request resolved: #128633

XuehaiPan added a commit that referenced this pull request Jul 10, 2024

Resolve circular dependence between torch.autograd and `torch.nn.pa…

8e121e5

…rameter` ghstack-source-id: adc22398c2d5d5f9fbd98d19ace7721313bc1c1a Pull Request resolved: #128633

Update

581df94

[ghstack-poisoned]

Update

2e225ea

[ghstack-poisoned]

This was referenced Jul 11, 2024

[Easy] reorder functions in torch._jit_internal #130531

Closed

[Easy] reorder functions in torch.nn.functional #130532

Open

XuehaiPan added a commit that referenced this pull request Jul 11, 2024

Resolve circular dependence between torch.autograd and `torch.nn.pa…

9bc901a

…rameter` ghstack-source-id: e8977d062f9af4dd38f5c8ae5da6e00454cb52ed Pull Request resolved: #128633

XuehaiPan marked this pull request as ready for review July 11, 2024 11:47

Update

f0cdcb4

[ghstack-poisoned]

Update

3893031

[ghstack-poisoned]

Update

fd61177

[ghstack-poisoned]

Update

d340994

[ghstack-poisoned]

XuehaiPan added a commit that referenced this pull request Jul 12, 2024

Resolve circular dependence between torch.autograd and `torch.nn.pa…

31b744d

…rameter` ghstack-source-id: 2cc2999a6eaf6b3e95396af8a2c08ad200ca15d8 Pull Request resolved: #128633

Update

7c86881

[ghstack-poisoned]

XuehaiPan added a commit that referenced this pull request Jul 13, 2024

Resolve circular dependence between torch.autograd and `torch.nn.pa…

205ac8e

…rameter` ghstack-source-id: 8c1cd943a21d2acbc72b249b1feac4091871ff86 Pull Request resolved: #128633

Update

081e714

[ghstack-poisoned]

XuehaiPan added a commit that referenced this pull request Jul 19, 2024

Resolve circular dependence between torch.autograd and `torch.nn.pa…

7adc9a4

…rameter` ghstack-source-id: c50623300c2d1b24116c61bf8a4b7350b3d5d00b Pull Request resolved: #128633

XuehaiPan linked an issue Jul 20, 2024 that may be closed by this pull request

[BUG] Circular dependency torch.nn.parameter -> torch.nn -> torch.autograd -> torch._C._autograd_init() -> torch.nn.parameter #128609

Open

Update

7f7fd30

[ghstack-poisoned]

XuehaiPan added a commit that referenced this pull request Jul 29, 2024

Resolve circular dependence between torch.autograd and `torch.nn.pa…

c9659bf

…rameter` ghstack-source-id: 957d639897b6ae381076395a17ab7773a693dcc2 Pull Request resolved: #128633

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resolve circular dependence between `torch.autograd` and `torch.nn.parameter` #128633

Resolve circular dependence between `torch.autograd` and `torch.nn.parameter` #128633

XuehaiPan commented Jun 13, 2024 •

edited

Loading

pytorch-bot bot commented Jun 13, 2024 •

edited

Loading

	auto parameter_module =
	THPObjectPtr(PyImport_ImportModule("torch.nn.parameter"));
	if (!parameter_module)
	return nullptr;

	// NOTE: "leaks" ParameterClass
	ParameterClass = PyObject_GetAttrString(parameter_module, "Parameter");
	if (!ParameterClass)
	return nullptr;

Resolve circular dependence between torch.autograd and torch.nn.parameter #128633

Are you sure you want to change the base?

Resolve circular dependence between torch.autograd and torch.nn.parameter #128633

Conversation

XuehaiPan commented Jun 13, 2024 • edited Loading

pytorch-bot bot commented Jun 13, 2024 • edited Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/128633

❌ 104 New Failures, 3 Unrelated Failures

Resolve circular dependence between `torch.autograd` and `torch.nn.parameter` #128633

Resolve circular dependence between `torch.autograd` and `torch.nn.parameter` #128633

XuehaiPan commented Jun 13, 2024 •

edited

Loading

pytorch-bot bot commented Jun 13, 2024 •

edited

Loading