Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] sort imports in torch.utils.data #127704

Closed
wants to merge 39 commits into from
Closed

[BE] sort imports in torch.utils.data #127704

wants to merge 39 commits into from

Conversation

XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Jun 2, 2024 •
edited
Loading

@XuehaiPan
Update
f4c56bf 
[ghstack-poisoned]
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 2, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/127704

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit a2f2556 with merge base 5ee893a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: dataloader release notes category label Jun 2, 2024
This was referenced Jun 2, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@XuehaiPan XuehaiPan added better-engineering Relatively self-contained tasks for better engineering contributors module: lint Issues related to our Python/C++ lint rules (run by Travis) labels Jun 2, 2024
@XuehaiPan XuehaiPan added the suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) label Jun 2, 2024
@XuehaiPan
Copy link
Collaborator Author

XuehaiPan commented Jun 2, 2024 •
edited
Loading

False positive for BC linter. Suppressing it.

Update the changes instead.

@XuehaiPan XuehaiPan removed the suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) label Jun 2, 2024
@XuehaiPan
Update
41f3657 
[ghstack-poisoned]
@XuehaiPan
Update
0bf40dc 
[ghstack-poisoned]
@XuehaiPan
Update
027daf8 
[ghstack-poisoned]
@XuehaiPan
Update
257f903 
[ghstack-poisoned]
@XuehaiPan
Update
0787bb3 
[ghstack-poisoned]
@XuehaiPan
Update
a7f028a 
[ghstack-poisoned]
@XuehaiPan XuehaiPan mentioned this pull request Jun 17, 2024
Open
@XuehaiPan
Update
329753f 
[ghstack-poisoned]
@XuehaiPan
Update
58f0f84 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 17, 2024
@XuehaiPan
[BE] sort imports in torch.utils.data
2673c05 
ghstack-source-id: 57bcae3e426180449b8e3f538fa99925ad42c85f
Pull Request resolved: pytorch#127704
@XuehaiPan
Update
c14ac67 
[ghstack-poisoned]
@XuehaiPan
Update
4f1296c 
[ghstack-poisoned]
@XuehaiPan XuehaiPan mentioned this pull request Jun 24, 2024
Closed
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 24, 2024
@XuehaiPan
[BE] sort imports in torch.utils.data
3317b19 
ghstack-source-id: ebae47cc3012316a1c8743c5d6861d5aa519a909
Pull Request resolved: pytorch#127704
@XuehaiPan
Update
6970668 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 24, 2024
@XuehaiPan
[BE] sort imports in torch.utils.data
f3d6317 
ghstack-source-id: 9c410b3c32946e17b2437d008e63632cbbdd9b0c
Pull Request resolved: pytorch#127704
@XuehaiPan
Update
7634435 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 25, 2024
@XuehaiPan
[BE] sort imports in torch.utils.data
29a9216 
ghstack-source-id: 7f24c84b4624ffa9f2fc4dfd22b5019ca53bc064
Pull Request resolved: pytorch#127704
@ezyang
Copy link
Contributor

ezyang commented Jun 27, 2024

btw it's ok (preferable, even) to squash these instead of stacking

@XuehaiPan
Update
a2f2556 
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Jun 27, 2024
@XuehaiPan
[BE] sort imports in torch.utils.data
e161891 
ghstack-source-id: 12ce126d4ee1e7ceedd55ff98053b5f89a1323d5
Pull Request resolved: pytorch#127704
pytorchmergebot pushed a commit that referenced this pull request Jun 27, 2024
@XuehaiPan @pytorchmergebot
[BE] enable UFMT in torch.utils.data (#127705)
7cf0b90 
Part of #123062

- #123062

Pull Request resolved: #127705
Approved by: https://github.com/ezyang
ghstack dependencies: #127706, #127704
@github-actions github-actions bot deleted the gh/XuehaiPan/40/head branch July 28, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezyang ezyang ezyang approved these changes

@andrewkho andrewkho Awaiting requested review from andrewkho

@gokulavasan gokulavasan Awaiting requested review from gokulavasan

Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors Merged module: lint Issues related to our Python/C++ lint rules (run by Travis) open source release notes: dataloader release notes category topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@XuehaiPan @andrewkho @ezyang @pytorchbot @pytorchmergebot