separate linux and darwin steps #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the release automation will fail to upload any binaries if any part of the 'fetch envoy' step fails. This is problematic because we currently attempt to fetch darwin binaries from Homebrew, but Homebrew does not build older patch releases of Envoy. As a temporary workaround, split the 'fetch envoy' step into two, and upload to the release right after fetching. This way, even if we cannot fetch the darwin binaries, we should still fetch and upload the linux binaries.
wasaga
approved these changes
Oct 11, 2023
| @@ -32,15 +32,18 @@ jobs: | |||
| eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)" | |||
| brew install oras | |||
|
|
|||
| - name: fetch envoy | |||
| - name: fetch and upload envoy (linux) | |||
There was a problem hiding this comment.
Maybe do a matrix {linux,Darwin} x {arm,x86}?
There was a problem hiding this comment.
Yes, that would allow each build to be fetched independently, but I think it might be simpler to start with this for now.
calebdoxsey
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the release automation will fail to upload any binaries if any part of the 'fetch envoy' step fails. This is problematic because we currently attempt to fetch darwin binaries from Homebrew, but Homebrew does not build older patch releases of Envoy.
As a temporary workaround, split the 'fetch envoy' step into two, and upload to the release right after fetching. This way, even if we cannot fetch the darwin binaries, we should still fetch and upload the linux binaries.