Skip to content

Commit

Permalink
separate linux and darwin steps (#50)
Browse files Browse the repository at this point in the history
Currently the release automation will fail to upload any binaries if any
part of the 'fetch envoy' step fails. This is problematic because we
currently attempt to fetch darwin binaries from Homebrew, but Homebrew
does not build older patch releases of Envoy.

As a temporary workaround, split the 'fetch envoy' step into two, and
upload to the release right after fetching. This way, even if we cannot
fetch the darwin binaries, we should still fetch and upload the linux
binaries.
  • Loading branch information
kenjenkins committed Oct 12, 2023
1 parent 8c5224f commit b960489
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,18 @@ jobs:
eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)"
brew install oras
- name: fetch envoy
- name: fetch and upload envoy (linux)
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
./scripts/fetch-envoy ${{ steps.tagName.outputs.tag }} darwin amd64
./scripts/fetch-envoy ${{ steps.tagName.outputs.tag }} darwin arm64
./scripts/fetch-envoy ${{ steps.tagName.outputs.tag }} linux amd64
./scripts/fetch-envoy ${{ steps.tagName.outputs.tag }} linux arm64
gh release upload ${{ steps.tagName.outputs.tag }} bin/envoy-linux-* --clobber
- name: Upload artifacts to release
- name: fetch and upload envoy (darwin)
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
gh release upload ${{ steps.tagName.outputs.tag }} bin/envoy-* --clobber
./scripts/fetch-envoy ${{ steps.tagName.outputs.tag }} darwin amd64
./scripts/fetch-envoy ${{ steps.tagName.outputs.tag }} darwin arm64
gh release upload ${{ steps.tagName.outputs.tag }} bin/envoy-darwin-* --clobber

0 comments on commit b960489

Please sign in to comment.