Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

separate linux and darwin steps #50

Merged
merged 1 commit into from
Oct 12, 2023
Merged

separate linux and darwin steps #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
separate linux and darwin steps 
Currently the release automation will fail to upload any binaries if any
part of the 'fetch envoy' step fails. This is problematic because we
currently attempt to fetch darwin binaries from Homebrew, but Homebrew
does not build older patch releases of Envoy.

As a temporary workaround, split the 'fetch envoy' step into two, and
upload to the release right after fetching. This way, even if we cannot
fetch the darwin binaries, we should still fetch and upload the linux
binaries.
  • Loading branch information
@kenjenkins
kenjenkins committed Oct 11, 2023
commit b7ac9e55e97eba072b0a34273477c610f2b716fc
13 changes: 8 additions & 5 deletions .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,18 @@ jobs:
eval "$(/home/linuxbrew/.linuxbrew/bin/brew shellenv)"
brew install oras

- name: fetch envoy
- name: fetch and upload envoy (linux)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe do a matrix {linux,Darwin} x {arm,x86}?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that would allow each build to be fetched independently, but I think it might be simpler to start with this for now.

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
./scripts/fetch-envoy ${{ steps.tagName.outputs.tag }} darwin amd64
./scripts/fetch-envoy ${{ steps.tagName.outputs.tag }} darwin arm64
./scripts/fetch-envoy ${{ steps.tagName.outputs.tag }} linux amd64
./scripts/fetch-envoy ${{ steps.tagName.outputs.tag }} linux arm64
gh release upload ${{ steps.tagName.outputs.tag }} bin/envoy-linux-* --clobber

- name: Upload artifacts to release
- name: fetch and upload envoy (darwin)
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
gh release upload ${{ steps.tagName.outputs.tag }} bin/envoy-* --clobber
./scripts/fetch-envoy ${{ steps.tagName.outputs.tag }} darwin amd64
./scripts/fetch-envoy ${{ steps.tagName.outputs.tag }} darwin arm64
gh release upload ${{ steps.tagName.outputs.tag }} bin/envoy-darwin-* --clobber