Reformatted the code

[giulio-coa]

I did some style improvements

[orazioedoardo]

Thanks but I think we should convert the entire script to a code style we agree on and then start requiring it, instead of spot pull requests. I'm about to start a discussion now.

[orazioedoardo]

Considering discussion #1573 and my previous comment, I wouldn't merge this pull request.

[giulio-coa]

If we can determine the code style rules, this PR can become the one that will reformat the code

[orazioedoardo]

I think it's better to wait for #1567 and then reformat the code on top of that, unless you want to force push all the time to handle conflicts.

[giulio-coa]

As mentioned in discussion #1573, I have reformatted the code according to the Google rules
Only file auto_install/install.sh is missing because I'm waiting for the merge of #1576

[coolapso]

LGTM

[orazioedoardo]

The 80 character limited suggested in the Google style guide is actually too restrictive IMHO, makes too many statements, variable definitions, commands more difficult to read, and probably slower too in cases like this when you need to call the command many times.

[coolapso]

The 80 character limited suggested in the Google style guide is actually too restrictive IMHO, makes too many statements, variable definitions, commands more difficult to read, and probably slower too in cases like this when you need to call the command many times.

Kinda agree, however having too big lines its also not that good. Guess we can agree in being flexible with that rule, and apply the 80 Chars rule whenever possible but open some exceptions where it actually doesn't help much.

[giulio-coa]

Kinda agree, however having too big lines its also not that good. Guess we can agree in being flexible with that rule, and apply the 80 Chars rule whenever possible but open some exceptions where it actually doesn't help much.

For sure, one exception will be " not apply the limit if it make the code less readable and/or harder to parse mentally"

[giulio-coa]

@orazioedoardo could you approve and merge the request ?

[orazioedoardo]

@giulio-coa I'm not sure I want to, as it is, considering this. To add, as I said before, this is much less readable than this.

[coolapso]

Ok then, let's try to not get lost here and not let this drag for too long.

We should apply the 80 Line rule whenever it is possible, however let's not get too strict about it and be flexible when to use it or not.

Let's get this merged when changes are applied, and later on if we feel that we should fix / review some lines, it can come on separate PR.

[coolapso]

🎉 This PR is included in version 4.1.0-test.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[coolapso]

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀