Remove dependencies

[giulio-coa]

Removed the dependency from edge repository and downloaded the grepcidr source code into a temp directory

[giulio-coa]

You've probably looked at an old commit
These are problems already fixed

[orazioedoardo]

You've probably looked at an old commit

If you go to the Files changed tab you can see that the script is still entering the relative directory.

[giulio-coa]

You've probably looked at an old commit

If you go to the Files changed tab you can see that the script is still entering the relative directory.

Yep
The problems were the downloads of the file not the cd into the directories

[orazioedoardo]

The problems were the downloads of the file not the cd into the directories

It is. Works for grepcidr because you are in the directory where the script is executed, most likely /home/pi (although I recommend using absolute paths there too in case someone changes the code above in the future), but it doesn't for apk-autoupdate because at that point you are in the /usr/local/src/pivpn directory.

./install.sh: line 2729: cd: apk-autoupdate-master: No such file or directory

[orazioedoardo]

Actually cd "${down_dir}/apk-autoupdate-master" still won't work because unzip and tar will extract in the current directory so the script should cd "${down_dir}" before unzip/unzip untar first.

[coolapso]

Following the angular convention, I think with PiVPN the build does not apply even tho we're dealing with an "external dependency", we don't rly have a build system. Here I think should be either refactor(): or fix():

[orazioedoardo]

Seems to be working but what's up with that asciidoctor?

[...]
install -d /etc/apk/
install -m 640 etc/autoupdate.conf /etc/apk/
install -d /usr/share/apk-autoupdate
for file in functions.sh openrc.sh; do \
	install -m 644 src/$file /usr/share/apk-autoupdate/$file; \
done
sed -e 's|@VERSION@|0.0.0|g' \
       -e 's|@datadir@|/usr/share/apk-autoupdate|g' \
       -e 's|@sysconfdir@|/etc|g' \
       src/apk-autoupdate.in > build/apk-autoupdate
chmod +x build/apk-autoupdate
cc  -Os -DNDEBUG -std=c11 -DVERSION=0.0.0 -o build/procs-need-restart.o -c src/procs-need-restart.c
cc  -o build/procs-need-restart build/procs-need-restart.o
sed -e 's|@VERSION@|0.0.0|g' \
       -e 's|@datadir@|/usr/share/apk-autoupdate|g' \
       -e 's|@sysconfdir@|/etc|g' \
       src/rc-service-pid.in > build/rc-service-pid
chmod +x build/rc-service-pid
install -d /usr/sbin
for file in apk-autoupdate procs-need-restart rc-service-pid; do \
	install -m 755 build/$file /usr/sbin/$file; \
done
asciidoctor -b manpage -o build/apk-autoupdate.1 man/apk-autoupdate.1.adoc
make: asciidoctor: No such file or directory
make: *** [Makefile:104: build/apk-autoupdate.1] Error 127
rm build/procs-need-restart.o
apk-autoupdate: Checking available updates...
apk-autoupdate: Upgrading packages:  busybox ssl_client busybox-suid python3 openssh-keygen openssh-client-common openssh-client-default openssh-sftp-server openssh-server-common openssh-server openssh
[...]

[orazioedoardo]

I see that you are not removing anymore downloaded files and build artifacts after compile, intentional?

[giulio-coa]

Seems to be working but what's up with that asciidoctor?

Probably, the dependency is missing
https://asciidoctor.org/

[giulio-coa]

I see that you are not removing anymore downloaded files and build artifacts after compile, intentional?

Yep
We use a temp directory, so ...

[orazioedoardo]

Probably, the dependency is missing
https://asciidoctor.org/

It’s used just for man pages, can you check whether sudo make install-conf install-data install-exec suppresses the error? See here.

[giulio-coa]

It’s used just for man pages, can you check whether sudo make install-conf install-data install-exec suppresses the error? See here.

I do, but wouldn't it be better to install asciidoctor?
I think it is better to install the package's man pages

[giulio-coa]

Probably, the dependency is missing
https://asciidoctor.org/

It’s used just for man pages, can you check whether sudo make install-conf install-data install-exec suppresses the error? See here.

It works

[orazioedoardo]

I do, but wouldn't it be better to install asciidoctor?
I think it is better to install the package's man pages

How much effort/code it is? I mean, it's not essential.

[giulio-coa]

How much effort/code it is? I mean, it's not essential.

For Pi-VPN, yes
You should consider that we install on the user's OS a package that s?he does not know building the source code
It seems appropriate to install the man pages, since it will not be able to install them via apk

[giulio-coa]

@orazioedoardo So, I can add asciidoctor as dependency or we merge the PR as is it ?

[orazioedoardo]

I can add asciidoctor as dependency

Yes

[coolapso]

🎉 This PR is included in version 4.1.0-test.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[coolapso]

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀