Added Alpine Linux support

[giulio-coa]

Good version of #1566

I have added the support for Alpine Linux.
The pre-requisites to run Pi-VPN on Alpine are:

• have bash installed (apk add bash)
• have busybox-initscripts installed (apk add busybox-initscripts)
• Obviously, run the scripts as root or have sudo installed (apk add sudo; echo '%wheel ALL=(ALL) ALL' > /etc/sudoers.d/wheel)

[giulio-coa]

@MichaIng @4s3ti maybe there is a bug in the test version of Pi-VPN.
The tests only fail on Focal and Bionic distributions and not on Xenial.
The bug don't seems related to any changes I've made.

[coolapso]

@MichaIng @4s3ti maybe there is a bug in the test version of Pi-VPN. The tests only fail on Focal and Bionic distributions and not on Xenial. The bug don't seems related to any changes I've made.

don't think there is any bug ... Just triggered the build and the current test is passing in all OS: https://app.travis-ci.com/github/pivpn/pivpn/builds/253283709 so should yours.

you can see the results of the failing tests by yourself, just click on the details.

here's the error: https://app.travis-ci.com/github/pivpn/pivpn/jobs/576888207#L606-L610

[giulio-coa]

@MichaIng @4s3ti maybe there is a bug in the test version of Pi-VPN. The tests only fail on Focal and Bionic distributions and not on Xenial. The bug don't seems related to any changes I've made.

don't think there is any bug ... Just triggered the build and the current test is passing in all OS: https://app.travis-ci.com/github/pivpn/pivpn/builds/253283709 so should yours.

you can see the results of the failing tests by yourself, just click on the details.

here's the error: https://app.travis-ci.com/github/pivpn/pivpn/jobs/576888207#L606-L610

I know, but this error is generated by a piece of code that I haven't touch ...
The only change that I have made on scripts/backup.sh is related to the check of an installed package

[coolapso]

@MichaIng @4s3ti maybe there is a bug in the test version of Pi-VPN. The tests only fail on Focal and Bionic distributions and not on Xenial. The bug don't seems related to any changes I've made.

don't think there is any bug ... Just triggered the build and the current test is passing in all OS: https://app.travis-ci.com/github/pivpn/pivpn/builds/253283709 so should yours.
you can see the results of the failing tests by yourself, just click on the details.
here's the error: https://app.travis-ci.com/github/pivpn/pivpn/jobs/576888207#L606-L610

I know, but this error is generated by a piece of code that I haven't touch ... The only change that I have made on scripts/backup.sh is related to the check of an installed package

The reason why is not Failing on Xenial is because the scripts tests run in a different way allowing them to fail, the same error is still there:

https://app.travis-ci.com/github/pivpn/pivpn/jobs/576888457#L487

indeed it seems not related with your changes but for some reason it is happening with your changes, not entirely sure why, and I am in the middle of house move hard for me to pay much attention.

[giulio-coa]

@MichaIng @4s3ti maybe there is a bug in the test version of Pi-VPN. The tests only fail on Focal and Bionic distributions and not on Xenial. The bug don't seems related to any changes I've made.

don't think there is any bug ... Just triggered the build and the current test is passing in all OS: https://app.travis-ci.com/github/pivpn/pivpn/builds/253283709 so should yours.
you can see the results of the failing tests by yourself, just click on the details.
here's the error: https://app.travis-ci.com/github/pivpn/pivpn/jobs/576888207#L606-L610

I know, but this error is generated by a piece of code that I haven't touch ... The only change that I have made on scripts/backup.sh is related to the check of an installed package

The reason why is not Failing on Xenial is because the scripts tests run in a different way allowing them to fail, the same error is still there:

https://app.travis-ci.com/github/pivpn/pivpn/jobs/576888457#L487

indeed it seems not related with your changes but for some reason it is happening with your changes, not entirely sure why, and I am in the middle of house move hard for me to pay much attention.

Glad I showed you a bug 😅

[MichaIng]

Some failures are related to the invalid user pi. Recent Raspberry Pi OS does not ship with this user anymore (Ubuntu of course never did), but on first boot or via RPi Imager one can create a custom login user manually. Before doing anything with pi, check getent passwd pi > /dev/null first, or handling of any hardcoded user could be removed completely. But again, worth a different PR 😉.

[coolapso]

LGTM, And seem you got it passing the CI as well during the weekend.

Will get it merged as soon as @orazioedoardo is happy with the changes. Great job all of you :D

[orazioedoardo]

pivpn debug will try to read from /var/log/openvpn.log so you could fallback to grep /var/log/messages or something.

This is still undecided. grep may be fragile, maybe just tell the user to take a look at /var/log/messages

[giulio-coa]

This is still undecided. grep may be fragile, maybe just tell the user to take a look at /var/log/messages

What do you think could be the best solution?
What would be the piece of code to add?

[orazioedoardo]

What would be the piece of code to add?

You could wrap this around a ${PLAT} check to disable on Alpine for now.

[orazioedoardo]

The script could download and install apk-autoupdate from git similar to what you do for grepcidr, but for now, I will merge.

[coolapso]

🎉 This PR is included in version 4.1.0-test.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[coolapso]

🎉 This PR is included in version 4.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀