Fixes part of #40: Added bottom padding to Question Player #3250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes part of #40: Added bottom padding to Question Player
Before this PR more than 2 test cases were failing on espresso in
QuestionPlayerActivityTest
that were fixed by adding the bottom-padding which was also a requirement as per mocks.But still 2 test cases are failing because of nested recyclerview for
SelectionInputInteraction
.In both these tests we want to scroll to
index=3
item of theselection_interaction_recycler_view
but the scrolling is disabled because it's an item ofquestion_recycler_view
and in current code we cannot scroll to this specific position.Output on Pixel 3 (5.56")
Output on Pixel 3 XL (6.3")
To fix this I have filed an issue #3370
Checklist