Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #3362: Used AccessibilityTestRule for Espresso Tests #3369

Merged
merged 2 commits into from
Jun 23, 2021

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jun 23, 2021

Explanation

Fixes part of #3362: Used AccessibilityTestRule for Espresso Tests

While using AccessibilityTestRule there were new/old errors identified. For all new errors I have used DisableAccessibilityChecks which will be solved in later PRs and for all old PRs I have filed issues mainly #3363 #3364 #3366 #3367

All Passing Tests

Screenshot 2021-06-23 at 2 10 39 PM

Screenshot 2021-06-23 at 2 11 43 PM

Screenshot 2021-06-23 at 2 18 55 PM

Screenshot 2021-06-23 at 2 22 11 PM

Screenshot 2021-06-23 at 2 24 36 PM

Screenshot 2021-06-23 at 2 26 41 PM

Screenshot 2021-06-23 at 2 29 47 PM

Screenshot 2021-06-23 at 2 37 36 PM

Screenshot 2021-06-23 at 2 39 02 PM

Screenshot 2021-06-23 at 3 09 29 PM

Screenshot 2021-06-23 at 3 13 22 PM

Screenshot 2021-06-23 at 3 54 29 PM

Screenshot 2021-06-23 at 3 56 00 PM

Screenshot 2021-06-23 at 3 57 33 PM

Screenshot 2021-06-23 at 4 00 11 PM

Screenshot 2021-06-23 at 4 00 52 PM

Screenshot 2021-06-23 at 4 04 45 PM

Screenshot 2021-06-23 at 4 08 41 PM

Screenshot 2021-06-23 at 4 11 27 PM

Screenshot 2021-06-23 at 4 12 36 PM

Screenshot 2021-06-23 at 4 14 38 PM

Screenshot 2021-06-23 at 4 17 40 PM

Screenshot 2021-06-23 at 4 19 05 PM

Screenshot 2021-06-23 at 4 21 40 PM

Screenshot 2021-06-23 at 4 22 57 PM

Screenshot 2021-06-23 at 4 41 16 PM

Screenshot 2021-06-23 at 4 45 36 PM

Screenshot 2021-06-23 at 4 52 37 PM

Screenshot 2021-06-23 at 4 54 39 PM

Screenshot 2021-06-23 at 4 55 03 PM

Screenshot 2021-06-23 at 5 31 03 PM

Screenshot 2021-06-23 at 5 34 30 PM

Screenshot 2021-06-23 at 5 35 54 PM

Screenshot 2021-06-23 at 5 38 17 PM

Screenshot 2021-06-23 at 5 43 33 PM

Screenshot 2021-06-23 at 5 44 38 PM

Screenshot 2021-06-23 at 5 49 41 PM

Screenshot 2021-06-23 at 5 52 26 PM

Screenshot 2021-06-23 at 6 03 41 PM

Screenshot 2021-06-23 at 6 12 37 PM

Screenshot 2021-06-23 at 6 15 19 PM

Screenshot 2021-06-23 at 6 18 23 PM

Screenshot 2021-06-23 at 6 47 51 PM

Screenshot 2021-06-23 at 6 48 22 PM

Screenshot 2021-06-23 at 6 52 43 PM

Failing Tests + Explanation

These tests are failing because these specific tests are meant to be run on Tablet device instead of mobile.
Screenshot 2021-06-23 at 3 44 07 PM

This test is meant to be run on Tablet device only
Screenshot 2021-06-23 at 4 25 24 PM

Filed issue #3366
Screenshot 2021-06-23 at 6 33 21 PM

Getting solved in #3250
Screenshot 2021-06-23 at 6 44 47 PM

Filed issue #3364
Screenshot 2021-06-23 at 5 27 04 PM

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oppiabot
Copy link

oppiabot bot commented Jun 23, 2021

Unassigning @anandwana001 since they have already approved the PR.

@oppiabot oppiabot bot added the PR: LGTM label Jun 23, 2021
@rt4914 rt4914 merged commit 847d52c into develop Jun 23, 2021
@rt4914 rt4914 deleted the use-a11y-test-rule-1 branch June 23, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants