Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Full UI: Question training interface [Blocked: #110, #27, #159] #40

Closed
4 tasks
BenHenning opened this issue Aug 2, 2019 · 8 comments · Fixed by #3426
Closed
4 tasks

Full UI: Question training interface [Blocked: #110, #27, #159] #40

BenHenning opened this issue Aug 2, 2019 · 8 comments · Fixed by #3426
Assignees
@rt4914
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
Ship Oppia on Android Prototype Oppia on Android

Comments

@BenHenning
Copy link
Sponsor Member

BenHenning commented Aug 2, 2019 •
edited
Loading

Learners should be able to assemble a random assortment of questions based on preselected skills to train and review those skills.

Specific things to complete (from #500):
@BenHenning BenHenning added Type: Improvement Priority: Essential This work item must be completed for its milestone. labels Aug 2, 2019
@BenHenning BenHenning added this to the Prototype milestone Aug 2, 2019
@BenHenning BenHenning added this to Triage in Ship Oppia on Android via automation Aug 2, 2019
@BenHenning
Copy link
Sponsor Member Author

This is blocked on #27 and #15.

This was referenced Aug 2, 2019
Open
Open
@BenHenning BenHenning moved this from Triage to Blocked in Ship Oppia on Android Aug 2, 2019
@BenHenning BenHenning changed the title Question training interface Question training interface [Blocked: #15, #27] Aug 12, 2019
@BenHenning BenHenning mentioned this issue Sep 17, 2019
Closed
@BenHenning BenHenning changed the title Question training interface [Blocked: #15, #27] Full UI: Question training interface [Blocked: #15, #27] Sep 20, 2019
@BenHenning BenHenning mentioned this issue Sep 20, 2019
Closed
9 tasks
@BenHenning BenHenning changed the title Full UI: Question training interface [Blocked: #15, #27] Full UI: Question training interface [Blocked: #110, #27] Sep 20, 2019
@BenHenning BenHenning changed the title Full UI: Question training interface [Blocked: #110, #27] Full UI: Question training interface [Blocked: #110, #27, #159] Sep 20, 2019
@BenHenning
Copy link
Sponsor Member Author

This actually also blocks on #159 and #110.

@BenHenning BenHenning added this to Triage in Prototype Oppia on Android via automation Sep 20, 2019
@BenHenning BenHenning moved this from Triage to Blocked in Prototype Oppia on Android Sep 20, 2019
@rt4914
Copy link
Contributor

rt4914 commented Nov 8, 2019

@BenHenning What is the difference between this issue and #27 ?

@BenHenning
Copy link
Sponsor Member Author

Closing #27 in favor of this one. That was based on assumptions of how the code would be laid out that didn't end up being true. Thanks for asking.

@BenHenning BenHenning mentioned this issue Nov 9, 2019
Closed
@rt4914
Copy link
Contributor

rt4914 commented Nov 9, 2019

Closing #27 in favor of this one. That was based on assumptions of how the code would be laid out that didn't end up being true. Thanks for asking.

Thanks for the update.

@BenHenning BenHenning mentioned this issue Nov 30, 2019
Closed
29 tasks
BenHenning added a commit that referenced this issue Sep 3, 2020
@BenHenning
Fix #387, #1771: Show concept cards (#1637)
56e91e4 
* Add support for showing concept cards in feedback, and add a concept
card as one of the remediation pathways for 'the meaning of equal parts'
lesson.

* Introduce test coroutine dispatchers support in Espresso.

This piggybacks off of the solution introduced in #1276 for Robolectric.
That PR allows Robolectric tests in app module to share dependencies
with production components by creating a test application & telling
Robolectric to use it instead of OppiaApplication via a @config
annotation.

This PR achieves the same thing by using a custom test runner that reads
the same annotation and forces Espresso & instrumentation to use the
test application instead of the default OppiaApplication. This setup
will be easier once #59 is finished since we can specify the application
in per-test manifests that both Robolectric & Espresso will respect.

Note that while this lets the same test coroutine dispatchers work in
both production & test code for Espresso, some additional work was
needed to ensure the coroutines behave correctly. In particular, the
coroutines use a fake system clock in Robolectric that requires explicit
synchronization points in the tests to allow the clock to move forward
& properly coordinate execution between background & main thread
operations. However, in Espresso, since everything is using a real clock
an idling resource is the preferred way to synchronize execution: it
allows the background coroutines to operate in real-time much like they
would in production, and then notify Espresso when completed. The test
dispatchers API is now setup to support both synchronization mechanisms
for both Robolectric & Espresso (the idling resource does nothing on
Robolectric and the force synchronization effectively does nothing on
Espresso).

The first test being demonstrated as now stable is SplashActivityTest
(as part of downstream work in #1397.

* Revert "Fixes #941: Add radar effect in Hints and solution (#1475)"

This reverts commit 41eb10b.

* Stabilize StateFragmentTest such that it passes on both Robolectric and
Espresso.

Note that some issues were found during this: #1612 (#1611 was found a
few weeks ago, but it also affects these tests). To ensure the tests can
still be run, a @runon annotation was added to allow tests to target
specific test platforms. The tests that currently fail on Robolectric
due to #1611 and #1612 are disabled for that platform. The test suite as
a whole has been verified to pass in its current state on both
Robolectric and Espresso (on a Pixel XL).

The aim of this PR is to actually enable critical state fragment tests
in CI, so both StateFragmentTest and StateFragmentLocalTest are being
enabled in GitHub actions.

* Enable StateFragmentTest (Robolectric) & StateFragmentLocalTest for CI.

* Add thorough documentation for new dispatchers.

* Clean up comments & add additional documentation.

* Fix lint errors.

* Fix broken test after changes to FakeSystemClock.

* Fix linter errors.

* Update test lesson to include references to concept cards.

* Lint fixes & use HtmlCompat instead of Html.

* Add support for the newer & finalized tag format.

* Lint fixes.

* Use a custom executor service for Glide requests that coordinates with
Oppia's test dispatchers. Note that this does not actually introduce the
service--that will happen in a new branch.

* Introduce new executor service which allows interop with Kotlin
coroutines, plus a test to verify that it fundamentally follows one
interpretation of ExecutorService's API.

* Fix flaky timeout tests by improving cancellation cooperation for
invokeAny() and provide longer timeouts for tests that are
CPU-sensitive.

* Add documentation & clean up unused code.

* Lint fixes.

* Significantly reorganize invokeAll() to try and make it more cooperative
for cancellation, and increase timeout times in tests to reduce
flakiness for time-sensitive tests. Some tests are remaining flaky, so
ignoring those.

Re-add maybeWithTimeoutOrNull since it actually was needed.

* Lint fixes.

* Post-merge module fixes.

* Post-merge fixes with ratio input & add a TODO to improve speed of the
new coroutine executor service.

* Revert "Fixes part of #40 & #42: Generalisation Highfi Mobile Portrait + Landscape - Buttons (#1653)"

This reverts commit 1bb1ffa.

* Ensure terminated tasks do not interfere with one another (timeouts
should happen individually for each task during termination). This fixes
a failure observed in StateFragmentLocalTest in #1630.

* Ignore failing tests until #1769 is resolved.

* Fix awaitTermination & improve test. Improve stack trace for test
dispatcher timeouts.

* Fix slow & broken tests in Robolectric for StateFragmentLocalTest.

* Add missing deps for StateFragmentLocalTest.

* Address TODOs (including adding support for list tags which replaces the
old handler & adds nested custom tag support), and add tests.

* Lint fixes.

* Address reviewer comments.

* Address review comments. Fix new concept card tests on Espresso & add
landscape versions (required configuring hints to show quickly to avoid
delaying the test, and fixing a bug in the espresso test dispatcher).
Add support for disabling concept cards of they aren't enabled for
parsing particular HTML (the default behavior is to ignore the custom
tag).

* Add support for concept cards in questions. Note that it's not clear how
to test verifying that pressing the exit button closes the concept card
since the exit button is part of the dialog's toolbar.

* Fix image-breaking duplicated code in HtmlParser, fix a paragraph
parsing issue in BulletTagHandler, and add tests for
CustomHtmlContentHandler.

* Lint fixes.
prayutsu pushed a commit to prayutsu/oppia-android that referenced this issue Sep 3, 2020
@BenHenning @prayutsu
Revert "Fixes part of oppia#40 & oppia#42: Generalisation Highfi Mobi…
fe79f42 
…le Portrait + Landscape - Buttons (oppia#1653)" (oppia#1768)

This reverts commit 1bb1ffa.
prayutsu pushed a commit to prayutsu/oppia-android that referenced this issue Sep 3, 2020
@BenHenning @prayutsu
Fix part of oppia#973: Introduce coroutine executor service (oppia#1764)
5920be3 
* Introduce new executor service which allows interop with Kotlin
coroutines, plus a test to verify that it fundamentally follows one
interpretation of ExecutorService's API.

* Fix flaky timeout tests by improving cancellation cooperation for
invokeAny() and provide longer timeouts for tests that are
CPU-sensitive.

* Add documentation & clean up unused code.

* Lint fixes.

* Significantly reorganize invokeAll() to try and make it more cooperative
for cancellation, and increase timeout times in tests to reduce
flakiness for time-sensitive tests. Some tests are remaining flaky, so
ignoring those.

Re-add maybeWithTimeoutOrNull since it actually was needed.

* Lint fixes.

* Revert "Fixes part of oppia#40 & oppia#42: Generalisation Highfi Mobile Portrait + Landscape - Buttons (oppia#1653)"

This reverts commit 1bb1ffa.

* Ensure terminated tasks do not interfere with one another (timeouts
should happen individually for each task during termination). This fixes
a failure observed in StateFragmentLocalTest in oppia#1630.

* Fix awaitTermination & improve test. Improve stack trace for test
dispatcher timeouts.

* Address reviewer comments.
prayutsu pushed a commit to prayutsu/oppia-android that referenced this issue Sep 3, 2020
@BenHenning @prayutsu
Fix part of oppia#973: Stabilize state fragment tests [Blocked: oppia…
fdff618 
…#1764] (oppia#1630)

* Introduce test coroutine dispatchers support in Espresso.

This piggybacks off of the solution introduced in oppia#1276 for Robolectric.
That PR allows Robolectric tests in app module to share dependencies
with production components by creating a test application & telling
Robolectric to use it instead of OppiaApplication via a @config
annotation.

This PR achieves the same thing by using a custom test runner that reads
the same annotation and forces Espresso & instrumentation to use the
test application instead of the default OppiaApplication. This setup
will be easier once oppia#59 is finished since we can specify the application
in per-test manifests that both Robolectric & Espresso will respect.

Note that while this lets the same test coroutine dispatchers work in
both production & test code for Espresso, some additional work was
needed to ensure the coroutines behave correctly. In particular, the
coroutines use a fake system clock in Robolectric that requires explicit
synchronization points in the tests to allow the clock to move forward
& properly coordinate execution between background & main thread
operations. However, in Espresso, since everything is using a real clock
an idling resource is the preferred way to synchronize execution: it
allows the background coroutines to operate in real-time much like they
would in production, and then notify Espresso when completed. The test
dispatchers API is now setup to support both synchronization mechanisms
for both Robolectric & Espresso (the idling resource does nothing on
Robolectric and the force synchronization effectively does nothing on
Espresso).

The first test being demonstrated as now stable is SplashActivityTest
(as part of downstream work in oppia#1397.

* Revert "Fixes oppia#941: Add radar effect in Hints and solution (oppia#1475)"

This reverts commit 41eb10b.

* Stabilize StateFragmentTest such that it passes on both Robolectric and
Espresso.

Note that some issues were found during this: oppia#1612 (oppia#1611 was found a
few weeks ago, but it also affects these tests). To ensure the tests can
still be run, a @runon annotation was added to allow tests to target
specific test platforms. The tests that currently fail on Robolectric
due to oppia#1611 and oppia#1612 are disabled for that platform. The test suite as
a whole has been verified to pass in its current state on both
Robolectric and Espresso (on a Pixel XL).

The aim of this PR is to actually enable critical state fragment tests
in CI, so both StateFragmentTest and StateFragmentLocalTest are being
enabled in GitHub actions.

* Enable StateFragmentTest (Robolectric) & StateFragmentLocalTest for CI.

* Add thorough documentation for new dispatchers.

* Clean up comments & add additional documentation.

* Fix lint errors.

* Fix broken test after changes to FakeSystemClock.

* Fix linter errors.

* Use a custom executor service for Glide requests that coordinates with
Oppia's test dispatchers. Note that this does not actually introduce the
service--that will happen in a new branch.

* Introduce new executor service which allows interop with Kotlin
coroutines, plus a test to verify that it fundamentally follows one
interpretation of ExecutorService's API.

* Fix flaky timeout tests by improving cancellation cooperation for
invokeAny() and provide longer timeouts for tests that are
CPU-sensitive.

* Add documentation & clean up unused code.

* Lint fixes.

* Significantly reorganize invokeAll() to try and make it more cooperative
for cancellation, and increase timeout times in tests to reduce
flakiness for time-sensitive tests. Some tests are remaining flaky, so
ignoring those.

Re-add maybeWithTimeoutOrNull since it actually was needed.

* Lint fixes.

* Post-merge module fixes.

* Post-merge fixes with ratio input & add a TODO to improve speed of the
new coroutine executor service.

* Revert "Fixes part of oppia#40 & oppia#42: Generalisation Highfi Mobile Portrait + Landscape - Buttons (oppia#1653)"

This reverts commit 1bb1ffa.

* Ensure terminated tasks do not interfere with one another (timeouts
should happen individually for each task during termination). This fixes
a failure observed in StateFragmentLocalTest in oppia#1630.

* Ignore failing tests until oppia#1769 is resolved.

* Fix awaitTermination & improve test. Improve stack trace for test
dispatcher timeouts.

* Fix slow & broken tests in Robolectric for StateFragmentLocalTest.

* Add missing deps for StateFragmentLocalTest.

* Address reviewer comments.
prayutsu pushed a commit to prayutsu/oppia-android that referenced this issue Sep 3, 2020
@BenHenning @prayutsu
Fix oppia#387, oppia#1771: Show concept cards (oppia#1637)
e35f2a4 
* Add support for showing concept cards in feedback, and add a concept
card as one of the remediation pathways for 'the meaning of equal parts'
lesson.

* Introduce test coroutine dispatchers support in Espresso.

This piggybacks off of the solution introduced in oppia#1276 for Robolectric.
That PR allows Robolectric tests in app module to share dependencies
with production components by creating a test application & telling
Robolectric to use it instead of OppiaApplication via a @config
annotation.

This PR achieves the same thing by using a custom test runner that reads
the same annotation and forces Espresso & instrumentation to use the
test application instead of the default OppiaApplication. This setup
will be easier once oppia#59 is finished since we can specify the application
in per-test manifests that both Robolectric & Espresso will respect.

Note that while this lets the same test coroutine dispatchers work in
both production & test code for Espresso, some additional work was
needed to ensure the coroutines behave correctly. In particular, the
coroutines use a fake system clock in Robolectric that requires explicit
synchronization points in the tests to allow the clock to move forward
& properly coordinate execution between background & main thread
operations. However, in Espresso, since everything is using a real clock
an idling resource is the preferred way to synchronize execution: it
allows the background coroutines to operate in real-time much like they
would in production, and then notify Espresso when completed. The test
dispatchers API is now setup to support both synchronization mechanisms
for both Robolectric & Espresso (the idling resource does nothing on
Robolectric and the force synchronization effectively does nothing on
Espresso).

The first test being demonstrated as now stable is SplashActivityTest
(as part of downstream work in oppia#1397.

* Revert "Fixes oppia#941: Add radar effect in Hints and solution (oppia#1475)"

This reverts commit 41eb10b.

* Stabilize StateFragmentTest such that it passes on both Robolectric and
Espresso.

Note that some issues were found during this: oppia#1612 (oppia#1611 was found a
few weeks ago, but it also affects these tests). To ensure the tests can
still be run, a @runon annotation was added to allow tests to target
specific test platforms. The tests that currently fail on Robolectric
due to oppia#1611 and oppia#1612 are disabled for that platform. The test suite as
a whole has been verified to pass in its current state on both
Robolectric and Espresso (on a Pixel XL).

The aim of this PR is to actually enable critical state fragment tests
in CI, so both StateFragmentTest and StateFragmentLocalTest are being
enabled in GitHub actions.

* Enable StateFragmentTest (Robolectric) & StateFragmentLocalTest for CI.

* Add thorough documentation for new dispatchers.

* Clean up comments & add additional documentation.

* Fix lint errors.

* Fix broken test after changes to FakeSystemClock.

* Fix linter errors.

* Update test lesson to include references to concept cards.

* Lint fixes & use HtmlCompat instead of Html.

* Add support for the newer & finalized tag format.

* Lint fixes.

* Use a custom executor service for Glide requests that coordinates with
Oppia's test dispatchers. Note that this does not actually introduce the
service--that will happen in a new branch.

* Introduce new executor service which allows interop with Kotlin
coroutines, plus a test to verify that it fundamentally follows one
interpretation of ExecutorService's API.

* Fix flaky timeout tests by improving cancellation cooperation for
invokeAny() and provide longer timeouts for tests that are
CPU-sensitive.

* Add documentation & clean up unused code.

* Lint fixes.

* Significantly reorganize invokeAll() to try and make it more cooperative
for cancellation, and increase timeout times in tests to reduce
flakiness for time-sensitive tests. Some tests are remaining flaky, so
ignoring those.

Re-add maybeWithTimeoutOrNull since it actually was needed.

* Lint fixes.

* Post-merge module fixes.

* Post-merge fixes with ratio input & add a TODO to improve speed of the
new coroutine executor service.

* Revert "Fixes part of oppia#40 & oppia#42: Generalisation Highfi Mobile Portrait + Landscape - Buttons (oppia#1653)"

This reverts commit 1bb1ffa.

* Ensure terminated tasks do not interfere with one another (timeouts
should happen individually for each task during termination). This fixes
a failure observed in StateFragmentLocalTest in oppia#1630.

* Ignore failing tests until oppia#1769 is resolved.

* Fix awaitTermination & improve test. Improve stack trace for test
dispatcher timeouts.

* Fix slow & broken tests in Robolectric for StateFragmentLocalTest.

* Add missing deps for StateFragmentLocalTest.

* Address TODOs (including adding support for list tags which replaces the
old handler & adds nested custom tag support), and add tests.

* Lint fixes.

* Address reviewer comments.

* Address review comments. Fix new concept card tests on Espresso & add
landscape versions (required configuring hints to show quickly to avoid
delaying the test, and fixing a bug in the espresso test dispatcher).
Add support for disabling concept cards of they aren't enabled for
parsing particular HTML (the default behavior is to ignore the custom
tag).

* Add support for concept cards in questions. Note that it's not clear how
to test verifying that pressing the exit button closes the concept card
since the exit button is part of the dialog's toolbar.

* Fix image-breaking duplicated code in HtmlParser, fix a paragraph
parsing issue in BulletTagHandler, and add tests for
CustomHtmlContentHandler.

* Lint fixes.
This was referenced May 6, 2021
Merged
Merged
rt4914 added a commit that referenced this issue May 11, 2021
@rt4914
Fixes part of #40 and Fixes part of #42: Highfi ItemSelectionInteract…
ed0f274 
…ion + A11y (#3170)

* Highfi work finished

* Nit space in comment

* A11y support

* Added tests

* Nit fix

* Ignored failing test cases

Co-authored-by: Rajat Talesra <[email protected]>
rt4914 added a commit that referenced this issue May 11, 2021
@rt4914
Fixes part of #40 & #42: Highfi InputInteraction (#3177)
9cc062c 
* Internal Highfi changes

* Outer margins fixed

* Nit fix

* Margin issue fixed

* Removed dimen values

* Introduced minHeight dimen

Co-authored-by: Rajat Talesra <[email protected]>
This was referenced May 11, 2021
Merged
Merged
Closed
rt4914 added a commit that referenced this issue May 13, 2021
@rt4914
Fixes part of #40 & #42: Previous Responses highfi + A11y (#3186)
7a2cede 
* All dimens created

* Added 12dp to start/end of margins

* Nit fixes

* Nit change

* Removed margin top dimens

Co-authored-by: Rajat Talesra <[email protected]>
This was referenced May 13, 2021
Merged
Merged
rt4914 added a commit that referenced this issue May 19, 2021
@rt4914
Fixes part of #40 & #42: Outer margins changed for SelectionInteracti…
97d5212 
…on (#3183)

* Outer margins changed for selection interaction

* Nit fixes and alignment fixes

Co-authored-by: Rajat Talesra <[email protected]>
anandwana001 pushed a commit that referenced this issue May 19, 2021
@rt4914
Fixes part of #40 & #42: Highfi buttons part 1 (#3197)
e193df7 
* Return to Topic UI Finished

* Replay button UI finished

* Reduced all margins by 4dp

* Reduced all margins by 4dp

* Button margins fixed

* Fixed splitview margins

* Nit fix

Co-authored-by: Rajat Talesra <[email protected]>
@rt4914 rt4914 mentioned this issue May 24, 2021
Merged
8 tasks
anandwana001 pushed a commit that referenced this issue May 24, 2021
@rt4914
Fixes part of #40 & #42: [A11y] Submit button (#3237)
b46da8b 
* Updated margin

* Added bottom padding

* A11y changes for submit button

Co-authored-by: Rajat Talesra <[email protected]>
@rt4914 rt4914 mentioned this issue May 25, 2021
Merged
8 tasks
@rt4914 rt4914 mentioned this issue Jun 7, 2021
Merged
8 tasks
rt4914 added a commit that referenced this issue Jun 8, 2021
@rt4914
Fixes part of #40 & #42: Highfi Submitted answer (#3273)
a8de5cf 
* Submitted answer outer margin

* Internal UI changes

Co-authored-by: Rajat Talesra <[email protected]>
@rt4914 rt4914 mentioned this issue Jun 29, 2021
Merged
8 tasks
anandwana001 pushed a commit that referenced this issue Jun 29, 2021
@rt4914
Fix part of #40 #42: Highfi drag and drop (#3385)
10c3260 
* External margins UI

* Internal non-recyclerview padding

* Full UI

* Full UI with accessibility

* Nit fix

Co-authored-by: Rajat Talesra <[email protected]>
BenHenning pushed a commit that referenced this issue Jul 6, 2021
@rt4914
Fixes part of #40: Added bottom padding to Question Player (#3250)
09e3692 
* Added bottom padding

* Added TODO

* Updated bottom padding

* Updated bottom padding

* Updated bottom padding correctly

Co-authored-by: Rajat Talesra <[email protected]>
@rt4914 rt4914 mentioned this issue Jul 7, 2021
Merged
8 tasks
Ship Oppia on Android automation moved this from Triage to Done Jul 7, 2021
anandwana001 pushed a commit that referenced this issue Jul 7, 2021
@rt4914
Fix #40: Highfi QuestionPlayerFragment xml files (#3426)
2d4f64c 
* Reformatted files

* Removed padding

Co-authored-by: Rajat Talesra <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Prototype Oppia on Android
  
Blocked
Ship Oppia on Android
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #40: Highfi QuestionPlayerFragment xml files oppia/oppia-android
2 participants
@rt4914 @BenHenning