Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #40 #42: Highfi drag and drop #3385

Merged
merged 5 commits into from
Jun 29, 2021
Merged

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jun 29, 2021

Explanation

Fixes part of #40

Fixes part of #42

Fixes part of #3251

Resources

Mobile Portrait 1
Mobile Portrait 2
Mobile Landscape
Tablet Portrait
Tablet Landscape
Split View Portrait
Split View Landscape

Internal UI

Tests Output

Screenshot 2021-06-29 at 1 04 34 PM

Screenshots

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Jun 29, 2021
@anandwana001 anandwana001 merged commit 10c3260 into develop Jun 29, 2021
@anandwana001 anandwana001 deleted the highfi-drag-and-drop branch June 29, 2021 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants