Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE-1.12] [SRVKS-661][Backport] Support http1 full duplex per workload #605

Merged

Conversation

skonto
Copy link

@skonto skonto commented Jan 26, 2024

What this PR does / why we need it:
Similar to #591.

Which issue(s) this PR fixes:

JIRA: SRVKS-661

Does this PR needs for other branches:

Does this PR (patch) needs to update/drop in the future?:

JIRA: "NONE"

…rkload (knative#14568) (knative#591)

* Support http1 full duplex per workload (knative#14568)

* support http1 full duplex per workload

* lint

* style

* single call

* updates & unit test

* fix unit test

* fix comment

* address review comments

* fix lint

* skip for Mac

* Create less load for TestActivatorChainHandlerWithFullDuplex (knative#14820)

* less load

* limit cons
@openshift-ci openshift-ci bot requested review from nak3 and rhuss January 26, 2024 15:05
@skonto skonto requested review from ReToCode and removed request for rhuss and nak3 January 26, 2024 15:05
Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link

openshift-ci bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit d691859 into openshift-knative:release-v1.12 Jan 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants