-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create less load for TestActivatorChainHandlerWithFullDuplex #14820
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14820 +/- ##
==========================================
- Coverage 85.95% 85.93% -0.03%
==========================================
Files 197 197
Lines 14991 14991
==========================================
- Hits 12885 12882 -3
- Misses 1793 1796 +3
Partials 313 313 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ReToCode, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…#14820) * less load * limit cons
…rkload (knative#14568) (#591) * Support http1 full duplex per workload (knative#14568) * support http1 full duplex per workload * lint * style * single call * updates & unit test * fix unit test * fix comment * address review comments * fix lint * skip for Mac * Create less load for TestActivatorChainHandlerWithFullDuplex (knative#14820) * less load * limit cons
Awesome - thanks for the quick fix for the flake |
…rkload (knative#14568) (knative#591) * Support http1 full duplex per workload (knative#14568) * support http1 full duplex per workload * lint * style * single call * updates & unit test * fix unit test * fix comment * address review comments * fix lint * skip for Mac * Create less load for TestActivatorChainHandlerWithFullDuplex (knative#14820) * less load * limit cons
…rkload (knative#14568) (#591) (#605) * Support http1 full duplex per workload (knative#14568) * support http1 full duplex per workload * lint * style * single call * updates & unit test * fix unit test * fix comment * address review comments * fix lint * skip for Mac * Create less load for TestActivatorChainHandlerWithFullDuplex (knative#14820) * less load * limit cons
Potentially fixes #14806
Proposed Changes
ah = WrapActivatorHandlerWithFullDuplex(ah, logger)
:FAIL
I am setting a con limit as in here, plus lowering the number of requests.