Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create less load for TestActivatorChainHandlerWithFullDuplex #14820

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

skonto
Copy link
Contributor

@skonto skonto commented Jan 22, 2024

Potentially fixes #14806

Proposed Changes

  • This patch drops the time that the test takes from ~1m to ~7s:

=== RUN TestActivatorChainHandlerWithFullDuplex
logger.go:130: 2024-01-22T15:05:08.626+0200 DEBUG configmap/store.go:155 activator config "config-tracing" config was added or updated: &config.Config{Backend:"none", ZipkinEndpoint:"", Debug:false, SampleRate:0.1}
--- PASS: TestActivatorChainHandlerWithFullDuplex (6.73s)
PASS

  • User can still reproduce the full duplex error if user comments out: ah = WrapActivatorHandlerWithFullDuplex(ah, logger):

=== RUN TestActivatorChainHandlerWithFullDuplex
logger.go:130: 2024-01-22T15:13:32.531+0200 DEBUG configmap/store.go:155 activator config "config-tracing" config was added or updated: &config.Config{Backend:"none", ZipkinEndpoint:"", Debug:false, SampleRate:0.1}
2024/01/22 15:13:39 httputil: ReverseProxy read error during body copy: read tcp 127.0.0.1:59348->127.0.0.1:38235: use of closed network connection
main_test.go:227: error during request: failed to read body: unexpected EOF
--- FAIL: TestActivatorChainHandlerWithFullDuplex (7.35s)

FAIL

2024/01/19 11:11:32 http: proxy error: dial tcp 127.0.0.1:37727: connect: cannot assign requested address
2024/01/19 11:11:32 http: proxy error: dial tcp 127.0.0.1:37727: connect: cannot assign requested address

I am setting a con limit as in here, plus lowering the number of requests.

@skonto skonto requested a review from dprotaso January 22, 2024 13:23
@knative-prow knative-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale area/networking size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 22, 2024
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9acc277) 85.95% compared to head (935890a) 85.93%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14820      +/-   ##
==========================================
- Coverage   85.95%   85.93%   -0.03%     
==========================================
  Files         197      197              
  Lines       14991    14991              
==========================================
- Hits        12885    12882       -3     
- Misses       1793     1796       +3     
  Partials      313      313              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ReToCode ReToCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
Copy link

knative-prow bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ReToCode, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 4928853 into knative:main Jan 22, 2024
49 checks passed
skonto added a commit to skonto/serving that referenced this pull request Jan 22, 2024
openshift-merge-bot bot pushed a commit to openshift-knative/serving that referenced this pull request Jan 23, 2024
…rkload (knative#14568) (#591)

* Support http1 full duplex per workload (knative#14568)

* support http1 full duplex per workload

* lint

* style

* single call

* updates & unit test

* fix unit test

* fix comment

* address review comments

* fix lint

* skip for Mac

* Create less load for TestActivatorChainHandlerWithFullDuplex (knative#14820)

* less load

* limit cons
@dprotaso
Copy link
Member

Awesome - thanks for the quick fix for the flake

skonto added a commit to skonto/serving that referenced this pull request Jan 26, 2024
…rkload (knative#14568) (knative#591)

* Support http1 full duplex per workload (knative#14568)

* support http1 full duplex per workload

* lint

* style

* single call

* updates & unit test

* fix unit test

* fix comment

* address review comments

* fix lint

* skip for Mac

* Create less load for TestActivatorChainHandlerWithFullDuplex (knative#14820)

* less load

* limit cons
openshift-merge-bot bot pushed a commit to openshift-knative/serving that referenced this pull request Jan 29, 2024
…rkload (knative#14568) (#591) (#605)

* Support http1 full duplex per workload (knative#14568)

* support http1 full duplex per workload

* lint

* style

* single call

* updates & unit test

* fix unit test

* fix comment

* address review comments

* fix lint

* skip for Mac

* Create less load for TestActivatorChainHandlerWithFullDuplex (knative#14820)

* less load

* limit cons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale area/networking lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestActivatorChainHandlerWithFullDuplex is flakey
3 participants