Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Service CRD to conformance tests #591

Closed
bobcatfish opened this issue Apr 5, 2018 · 6 comments
Closed

Add Service CRD to conformance tests #591

bobcatfish opened this issue Apr 5, 2018 · 6 comments
Assignees
Labels
area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@bobcatfish
Copy link
Contributor

Expected Behavior

In #577 we have added a new CRD type which is part of the core Elafros API.

Actual Behavior

This new CRD should be tested in the conformance tests.

Additional Info

Waiting on controller implementation by @vaikas-google and spec/docs from @evankanderson .

@vaikas
Copy link
Contributor

vaikas commented Apr 5, 2018

Once #597 goes in we should be able to start adding conformance tests.

@mattmoor mattmoor added the area/test-and-release It flags unit/e2e/conformance/perf test issues for product features label Apr 9, 2018
@bobcatfish
Copy link
Contributor Author

@jonjohnsonjr I think you're working on this so I've assigned it to you but feel free to assign it back if that's wrong!

@evankanderson
Copy link
Member

/kind cleanup

Jon, any updates here?

@google-prow-robot google-prow-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 22, 2018
@jonjohnsonjr
Copy link
Contributor

Very close to having a working happy path, with unhappy paths to follow soon after. I had to actually make it conform before I can land the test, currently waiting on #1330 /cc @mattmoor

Something working 👍 will have a PR once I clean this up!

go test -v -tags=e2e -count=1 ./test/conformance -run ^TestRunLatestService
=== RUN   TestRunLatestService
I0625 17:49:59.670672   31051 crd.go:94] Seeding rand.Rand with 1529948999670662769
2018/06/25 17:49:59 Creating a new Service
2018/06/25 17:49:59 The Service will be updated with the name of the Revision once it is created
2018/06/25 17:50:00 The Service will be updated with the domain of the Route once it is created
I0625 17:50:01.096818   31051 service_test.go:74] When the Service reports as Ready, everything should be ready.
I0625 17:50:09.266356   31051 request.go:97] Wait for the endpoint to be up and handling requests
I0625 17:50:09.355583   31051 request.go:59] Retrying for code 404
I0625 17:50:10.403666   31051 request.go:59] Retrying for code 404
I0625 17:50:11.406270   31051 request.go:59] Retrying for code 404
I0625 17:50:12.400924   31051 request.go:59] Retrying for code 404
I0625 17:50:13.406410   31051 request.go:59] Retrying for code 404
I0625 17:50:14.405315   31051 service_test.go:95] The Revision will be marked as Ready when it can serve traffic
I0625 17:50:14.452411   31051 service_test.go:100] Updates the Configuration that the Revision is ready
I0625 17:50:14.526891   31051 service_test.go:107] Updates the Route to route traffic to the Revision
I0625 17:50:14.584995   31051 service_test.go:186] Updating the Service to use a different image
I0625 17:50:14.643911   31051 service_test.go:192] Since the Service was updated a new Revision will be created and the Service will be updated
I0625 17:50:15.749954   31051 service_test.go:74] When the Service reports as Ready, everything should be ready.
I0625 17:50:19.890759   31051 request.go:97] Wait for the endpoint to be up and handling requests
I0625 17:50:28.985143   31051 service_test.go:95] The Revision will be marked as Ready when it can serve traffic
I0625 17:50:29.031560   31051 service_test.go:100] Updates the Configuration that the Revision is ready
I0625 17:50:29.074448   31051 service_test.go:107] Updates the Route to route traffic to the Revision
--- PASS: TestRunLatestService (29.50s)
PASS
ok  	github.com/knative/serving/test/conformance	29.507s

@bobcatfish
Copy link
Contributor Author

Something working +1 will have a PR once I clean this up!

wooooooot

image

@mattmoor
Copy link
Member

I think between what @jonjohnsonjr and @dgerd have added, our conformance test coverage of the Service resource has gotten pretty good. I'm going to close this as done since I feel like most of our gaps lie outside of what I'd consider the scope of this issue.

ReToCode pushed a commit to ReToCode/serving that referenced this issue Jan 23, 2024
…rkload (knative#14568) (knative#591)

* Support http1 full duplex per workload (knative#14568)

* support http1 full duplex per workload

* lint

* style

* single call

* updates & unit test

* fix unit test

* fix comment

* address review comments

* fix lint

* skip for Mac

* Create less load for TestActivatorChainHandlerWithFullDuplex (knative#14820)

* less load

* limit cons
skonto added a commit to skonto/serving that referenced this issue Jan 26, 2024
…rkload (knative#14568) (knative#591)

* Support http1 full duplex per workload (knative#14568)

* support http1 full duplex per workload

* lint

* style

* single call

* updates & unit test

* fix unit test

* fix comment

* address review comments

* fix lint

* skip for Mac

* Create less load for TestActivatorChainHandlerWithFullDuplex (knative#14820)

* less load

* limit cons
mgencur pushed a commit to mgencur/serving-1 that referenced this issue Mar 7, 2024
…rkload (knative#14568) (knative#591) (knative#605)

* Support http1 full duplex per workload (knative#14568)

* support http1 full duplex per workload

* lint

* style

* single call

* updates & unit test

* fix unit test

* fix comment

* address review comments

* fix lint

* skip for Mac

* Create less load for TestActivatorChainHandlerWithFullDuplex (knative#14820)

* less load

* limit cons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test-and-release It flags unit/e2e/conformance/perf test issues for product features kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

6 participants