Move to Jest Expect #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tizmagik let me know if you need any changes on this |
tizmagik
reviewed
Oct 5, 2017
tests/PromiseMiddleware.test.js
Outdated
|
|
||
| actionHandler(actionObj); | ||
|
|
||
| expect(actionSpy.calledOnce).toBeTruthy(); | ||
| expect(actionSpy.firstCall.args[0]).toEqual(actionObj); |
There was a problem hiding this comment.
I think you can actually drop sinon and get away with using Jest's built-in spy, jest.fn() here and elsewhere. For example:
const actionSpy = jest.fn();
const actionHandler = nextHandler(actionSpy);
actionHandler(actionObj);
expect(actionSpy).toHaveBeenCalledTimes(1);
expect(actionSpy).toHaveBeenCalledWith(actionObj);
|
@tizmagik Jest mocks for the win. They actually reduced a few areas down a bit which was nice. I also fixed the skipped test in |
Merged
tizmagik
approved these changes
Oct 6, 2017
tizmagik
pushed a commit
that referenced
this pull request
Oct 6, 2017
* Initial jest conversion * Remove macho setup and remove jsdom package. * PromiseMiddleware test refactor. * Refactor ReduxTaxi tests to jest expect * Refactor ReduxTaxiMiddleware test to jest expect * Refactor ReduxTaxiProvider to jest expect * Refactor RegisterAsyncActions test to jest expect * Remove chai package * Remove trailing commas * Add Prettier * Add Prettier * Update list-staged file catch * Run Prettier on all JS files * Remove sinon in favor for jest mocks. * removing prettier deps from this PR. * packages. * Prettier pre-hook and reformat current files. * 2 spaces in editorconfig. * Create .travis.yml (#11) * Create .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Move to Jest Expect (#6) * Initial jest conversion * Remove macho setup and remove jsdom package. * PromiseMiddleware test refactor. * Refactor ReduxTaxi tests to jest expect * Refactor ReduxTaxiMiddleware test to jest expect * Refactor ReduxTaxiProvider to jest expect * Refactor RegisterAsyncActions test to jest expect * Remove chai package * Remove trailing commas * Add Prettier * Add Prettier * Update list-staged file catch * Run Prettier on all JS files * Remove sinon in favor for jest mocks. * removing prettier deps from this PR. * remove trailing comma * Initial jest conversion * Remove macho setup and remove jsdom package. * Remove chai package * Remove trailing commas * Add Prettier * Add Prettier * Update list-staged file catch * Run Prettier on all JS files * Remove sinon in favor for jest mocks. * removing prettier deps from this PR. * packages. * Prettier pre-hook and reformat current files. * 2 spaces in editorconfig.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
chaipackage which was primarily using theassertstyle tests in favour of using standardjestexceptassertions.All tests are passing as they were before, in the process of converting I refactored the tests to read a bit better. There were a few tests in
PromiseMiddleware.test.jsthat were throwingunhandled promise rejectionwarnings, these have all been resolved through the reorganization of the tests.I opted to use
sinon.spy's to assist in the readability of the tests.This will complete #3
Closes #3