Add Prettier Pre-Hook #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
* Create .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml * Update .travis.yml
* Initial jest conversion * Remove macho setup and remove jsdom package. * PromiseMiddleware test refactor. * Refactor ReduxTaxi tests to jest expect * Refactor ReduxTaxiMiddleware test to jest expect * Refactor ReduxTaxiProvider to jest expect * Refactor RegisterAsyncActions test to jest expect * Remove chai package * Remove trailing commas * Add Prettier * Add Prettier * Update list-staged file catch * Run Prettier on all JS files * Remove sinon in favor for jest mocks. * removing prettier deps from this PR. * remove trailing comma
|
@tizmagik Working on it now. |
|
@tizmagik All good to go now, That was a rough resolve haha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this was closed and re-opened because of an issue with a merge.
As I was working on Jest test conversions I noticed small little inconsistencies with conventions so this PR is adding Prettier as a
precommithook.The way it works is any
js,jsonfiles that are staged will have prettier on them applied right beforegit commitis ran. It will clean up any small syntax issues to enforce a consistent convention. I set the pretty flags to my personal preference however that can be updated easily.Prettier setup:
I would suggest getting a prettier package for whichever editor you are using and put
Format on saveon, however this will catch changes going forward.All current
.js, .jsonfiles have been prettiered.Note Once #6 is merged this PR will be easier to remove.
Closes #8