Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Prettier Pre-Commit Hook #7

Closed
wants to merge 15 commits into from
Closed

Conversation

frytyler
Copy link
Contributor

@frytyler frytyler commented Oct 4, 2017

As I was working on Jest test conversions I noticed small little inconsistencies with conventions so this PR is adding Prettier as a precommit hook.

The way it works is any js,json files that are staged will have prettier on them applied right before git commit is ran. It will clean up any small syntax issues to enforce a consistent convention. I set the pretty flags to my personal preference however that can be updated easily.

Prettier setup:

prettier --write --trailing-comma es5 --single-quote --tab-width 4
  • Trailing commas in objects not functions.
  • single quote for arguments.
  • tab width set to 4 spaces.

I would suggest getting a prettier package for whichever editor you are using and put Format on save on, however this will catch changes going forward.

All current .js, .json files have been prettiered.

Note Once #6 is merged this PR will be easier to remove.

Closes #8

@tizmagik tizmagik mentioned this pull request Oct 5, 2017
@tizmagik
Copy link
Contributor

tizmagik commented Oct 5, 2017

Sweet, thank you! I'll merge this after #6 lands.

I created an issue and added a Hacktoberfest label for ya 😁

package.json Outdated
},
"lint-staged": {
"*.{js,json}": [
"prettier --write --trailing-comma es5 --single-quote --tab-width 4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--tab-width 2 please 😁

@frytyler frytyler closed this Oct 5, 2017
@frytyler frytyler deleted the prettier branch October 5, 2017 15:25
@tizmagik
Copy link
Contributor

tizmagik commented Oct 5, 2017

@frytyler why the close?

@tizmagik
Copy link
Contributor

tizmagik commented Oct 5, 2017

Oh I see you opened another PR, 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants