Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Add ds001771 to the smoke-tests battery #91

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

oesteban
Copy link
Member

Revise the organization of the CircleCI config to leverage the new flag --fs-subjects-dir.

Revise the organization of the CircleCI config to leverage the new flag
``--fs-subjects-dir``.
@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     MAINT: Add ds001771 to the smoke-tests battery

Powered by Pull Assistant. Last update 9477da7 ... 9477da7. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #91 into master will not change coverage by %.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   51.64%   51.64%           
=======================================
  Files          21       21           
  Lines        1218     1218           
  Branches      161      161           
=======================================
  Hits          629      629           
  Misses        578      578           
  Partials       11       11           
Impacted Files Coverage Δ
dmriprep/cli/parser.py 56.57% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3aec266...9477da7. Read the comment docs.

@oesteban
Copy link
Member Author

Alright, this is working (as in, the new smoke test is up and running).

I'm going to merge this, and therefore break master to put some load on @josephmje (#90) and @dPys (#82). Please let me know if you need any help guys.

@oesteban oesteban merged commit f5c9a4f into nipreps:master Mar 24, 2020
@oesteban oesteban deleted the enh/add-smoke-test-new-data branch March 24, 2020 00:36
@josephmje
Copy link
Collaborator

Revise the organization of the CircleCI config to leverage the new flag --fs-subjects-dir.

I don't see the --fs-subjects-dir flag in the CLI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants