Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Borked reference & mask after sloppy merge #90

Closed
oesteban opened this issue Mar 23, 2020 · 2 comments · Fixed by #101
Closed

BUG: Borked reference & mask after sloppy merge #90

oesteban opened this issue Mar 23, 2020 · 2 comments · Fixed by #101
Assignees
@josephmje
Labels
bug Something isn't working effort: medium This task can be undertaken in a reasonable amount of time impact: high This contribution/idea will help a lot of people
Milestone
0.3.0

Comments

@oesteban
Copy link
Member

oesteban commented Mar 23, 2020 •
edited
Loading

Although I'd swear I checked on the reports before merging #81, it seems I didn't look properly or didn't check at all.

https://25-233707741-gh.circle-artifacts.com/0/tmp/THP002/derivatives/dmriprep/sub-THP0005.html#acquisition-GD72_datatype-dwi_desc-brain_run-1_session-THP0005JHU1_suffix-mask
@oesteban oesteban added the bug Something isn't working label Mar 23, 2020
@oesteban oesteban added this to the 0.3.0 milestone Mar 23, 2020
@oesteban oesteban added impact: high This contribution/idea will help a lot of people effort: medium This task can be undertaken in a reasonable amount of time labels Mar 23, 2020
@oesteban oesteban mentioned this issue Mar 24, 2020
Merged
@josephmje
Copy link
Collaborator

Thanks @oesteban . Will take a look!

@oesteban
Copy link
Member Author

oesteban commented Apr 6, 2020

Looking at this right now. @josephmje should I hold off? Have you started with this?

@oesteban oesteban mentioned this issue Apr 6, 2020
Merged
oesteban added a commit to oesteban/dmriprep that referenced this issue Apr 7, 2020
@oesteban
FIX: Minor refactor of DWI/brainmasks utilities and dtypes
f3cf0c5 
This PR:

  * [x] Handles the data dtypes more carefully, avoiding casting to
    floats whenever possible.
  * [x] Adds a ``signal_drift`` output to the ``RescaleB0`` interface
    to reuse down the line.

Future lines
------------
We should think about dropping FSL MCFLIRT, which is used for HMC of the
b-zero volumes.

Resolves: nipreps#90
@oesteban oesteban mentioned this issue Apr 7, 2020
Merged
3 tasks
oesteban added a commit to oesteban/dmriprep that referenced this issue Apr 7, 2020
@oesteban
FIX: Minor refactor of DWI/brainmasks utilities and dtypes
a66d685 
This PR:

  * [x] Handles the data dtypes more carefully, avoiding casting to
    floats whenever possible.
  * [x] Adds a ``signal_drift`` output to the ``RescaleB0`` interface
    to reuse down the line.

Future lines
------------
We should think about dropping FSL MCFLIRT, which is used for HMC of the
b-zero volumes.

Resolves: nipreps#90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephmje josephmje

Labels
bug Something isn't working effort: medium This task can be undertaken in a reasonable amount of time impact: high This contribution/idea will help a lot of people
Projects
None yet
Milestone
0.3.0
Development

Successfully merging a pull request may close this issue.

FIX: Minor refactor of DWI/brainmasks utilities and dtypes oesteban/dmriprep
2 participants
@oesteban @josephmje