Crop preset review #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok to test |
seonim-ryu
reviewed
Oct 31, 2018
src/js/component/cropper.js
Outdated
| left: -10, | ||
| height: 1, | ||
| width: 1 | ||
| }); |
There was a problem hiding this comment.
defaultOption으로 해서 객체 빼는건 어떨까요?
There was a problem hiding this comment.
factor 그냥.. 1이 아닌 경우에 1로 초기화 하고 this._getPresetCropSizePosition(factor) 호출하는거로 하면 될듯해요
seonim-ryu
reviewed
Oct 31, 2018
src/js/component/cropper.js
Outdated
| const standardSize = (originalWidth >= originalHeight) ? originalWidth : originalHeight; | ||
| const getScale = (value, orignalValue) => (value > orignalValue) ? orignalValue / value : 1; | ||
|
|
||
| let width = (standardSize * factor); |
seonim-ryu
reviewed
Oct 31, 2018
src/js/ui/crop.js
Outdated
| } | ||
|
|
||
| /** | ||
| * Add event for crop | ||
| * @param {Object} actions - actions for crop | ||
| * @param {Function} actions.crop - crop action | ||
| * @param {Function} actions.cancel - cancel action | ||
| * @param {Function} actions.preset - cancel action |
seonim-ryu
reviewed
Oct 31, 2018
src/js/component/cropper.js
Outdated
| @@ -277,6 +278,64 @@ class Cropper extends Component { | |||
| }; | |||
| } | |||
|
|
|||
| /** | |||
| * Set a cropzone square | |||
| * @param {number} factor - preset ratio | |||
There was a problem hiding this comment.
factor->scale파라미터명 변경- 파라미터가 비어있는 경우 ->
[factor]변경
seonim-ryu
reviewed
Oct 31, 2018
seonim-ryu
reviewed
Oct 31, 2018
|
|
||
| /** | ||
| * Set preset button to active status | ||
| * @param {HTMLElement} button - event target element |
seonim-ryu
reviewed
Oct 31, 2018
| * @param {HTMLElement} button - event target element | ||
| */ | ||
| _setPresetButtonActive(button = this.defaultPresetButton) { | ||
| snippet.forEach([].slice.call(this._els.preset.querySelectorAll('.preset')), presetButton => { |
There was a problem hiding this comment.
[].slice.call -> 코드스니펫 메서드로 변경
There was a problem hiding this comment.
snippet에 따로 없고 예제에서도 따로 slice 해주라고 하네요. 이대로 하는게 좋을것 같습니다
|
[10/31] 리뷰 완료요~ |
|
[10/31] 리뷰 완료했습니다. |
sohee-lee7
reviewed
Oct 31, 2018
| </li> | ||
| <li class="tui-image-editor-partition tui-image-editor-newline"> | ||
| </li> | ||
| <li class="tui-image-editor-partition only-left-right"> |
There was a problem hiding this comment.
메뉴 바 정렬이 left나 right로 되어 있을때만 보여야 하는 라인입니다.
There was a problem hiding this comment.
가능하면 태그 한줄로 처리하는 방법을 찾아보겠습니다.
|
[10/31] 리뷰 완료입니다 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work
example