Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds crop selection presets (square, 3:2, 4:3, 5:4, 7:5, 16:9) #54

Merged
merged 3 commits into from
Oct 31, 2018

Conversation

joelabair
Copy link
Contributor

@joelabair joelabair commented Aug 23, 2018

Please check if the PR fulfills these requirements

  • It's submitted to right branch according to our branching model
  • It's right issue type on title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has description for the breaking change

Description


Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@seonim-ryu
Copy link
Member

Can one of the admins verify this patch?

@jinwoo-kim-nhn
Copy link
Contributor

thank you for the contribution @joelabair
let me take a time to review this PR

@intelicloud
Copy link

I also need this feature. Is it possible to push it on master?

@jinwoo-kim-nhn jinwoo-kim-nhn mentioned this pull request Oct 31, 2018
@jinwoo-kim-nhn jinwoo-kim-nhn merged commit d688045 into nhn:master Oct 31, 2018
HerlinMatos pushed a commit to EveryMundo/tui.image-editor that referenced this pull request Jul 2, 2020
…hn#54)

* crop presets

* reset state

* added test cases for preset cropzone functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants