Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crop preset review #84

Merged
merged 11 commits into from
Oct 31, 2018
Merged

Crop preset review #84

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6ea90ba
For pr review
jinwoo-kim-nhn Oct 30, 2018
1cc54e1
some refector
jinwoo-kim-nhn Oct 30, 2018
642f5aa
fixed code from review
jinwoo-kim-nhn Oct 30, 2018
76c3406
fixed use snippet 'map' and 'foreach' for ie9
jinwoo-kim-nhn Oct 31, 2018
a556ef6
Changed method declaration order of cropper.js
jinwoo-kim-nhn Oct 31, 2018
d8ec604
fixed test code
jinwoo-kim-nhn Oct 31, 2018
67935b3
Apply code review
jinwoo-kim-nhn Oct 31, 2018
8478bf7
refactor: change argument name
jinwoo-kim-nhn Oct 31, 2018
8da6601
Merge branch 'master' into crop-preset-review
jinwoo-kim-nhn Oct 31, 2018
4fee353
fixed conflict
jinwoo-kim-nhn Oct 31, 2018
7e14b16
apply codereview for css
jinwoo-kim-nhn Oct 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed test code
  • Loading branch information
@jinwoo-kim-nhn
jinwoo-kim-nhn committed Oct 31, 2018
commit d8ec6049b3ca71131ce754d13e8b2880129e2471
36 changes: 14 additions & 22 deletions test/cropper.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,68 +241,62 @@ describe('Cropper', () => {
});

describe('"presets - setCropzoneRect()"', () => {
it('should return cropzone rect as a square', () => {
beforeEach(() => {
cropper.start();
});

afterEach(() => {
cropper.end();
});

it('should return cropzone rect as a square', () => {
spyOn(cropper._cropzone, 'isValid').and.returnValue(true);
cropper.setCropzoneRect(1 / 1);
expect(cropper.getCropzoneRect()).toBeTruthy();

expect(cropper.getCropzoneRect().width).toBe(cropper.getCropzoneRect().height);
cropper.end();
});

it('should return cropzone rect as a 3:2 aspect box', () => {
cropper.start();
spyOn(cropper._cropzone, 'isValid').and.returnValue(true);
cropper.setCropzoneRect(3 / 2);
expect(cropper.getCropzoneRect()).toBeTruthy();

expect((cropper.getCropzoneRect().width / cropper.getCropzoneRect().height).toFixed(1))
.toBe((3 / 2).toFixed(1));
cropper.end();
});

it('should return cropzone rect as a 4:3 aspect box', () => {
cropper.start();
spyOn(cropper._cropzone, 'isValid').and.returnValue(true);
cropper.setCropzoneRect(4 / 3);
expect(cropper.getCropzoneRect()).toBeTruthy();

expect((cropper.getCropzoneRect().width / cropper.getCropzoneRect().height).toFixed(1))
.toBe((4 / 3).toFixed(1));
cropper.end();
});

it('should return cropzone rect as a 5:4 aspect box', () => {
cropper.start();
spyOn(cropper._cropzone, 'isValid').and.returnValue(true);
cropper.setCropzoneRect(5 / 4);
expect(cropper.getCropzoneRect()).toBeTruthy();

expect((cropper.getCropzoneRect().width / cropper.getCropzoneRect().height).toFixed(1))
.toBe((5 / 4).toFixed(1));
cropper.end();
});

it('should return cropzone rect as a 7:5 aspect box', () => {
cropper.start();
spyOn(cropper._cropzone, 'isValid').and.returnValue(true);
cropper.setCropzoneRect(7 / 5);
expect(cropper.getCropzoneRect()).toBeTruthy();

expect((cropper.getCropzoneRect().width / cropper.getCropzoneRect().height).toFixed(1))
.toBe((7 / 5).toFixed(1));
cropper.end();
});

it('should return cropzone rect as a 16:9 aspect box', () => {
cropper.start();
spyOn(cropper._cropzone, 'isValid').and.returnValue(true);
cropper.setCropzoneRect(16 / 9);
expect(cropper.getCropzoneRect()).toBeTruthy();

expect((cropper.getCropzoneRect().width / cropper.getCropzoneRect().height).toFixed(1))
.toBe((16 / 9).toFixed(1));
cropper.end();
});

it('should remove cropzone of cropper when falsy is passed', () => {
cropper.start();

cropper.setCropzoneRect();
expect(cropper.getCropzoneRect()).toBeFalsy();

Expand All @@ -311,8 +305,6 @@ describe('Cropper', () => {

cropper.setCropzoneRect(null);
expect(cropper.getCropzoneRect()).toBeFalsy();

cropper.end();
});
});

Expand Down